IPv4/Single: Add a SocketID to a socket #546

htibosch · 2022-09-02T06:26:32Z

Description

In issue #540, Jabob Carver is asking for the possibility to assign a unique ID to each socket.

We found that a good idea and this PR adds it, depending on the new macro ipconfigUSE_SetSocketID.

In many applications, sockets are embedded in an object, a class. The "SetSocketID" can be a pointer to the instance of that class.
These will be the new functions:

BaseType_t xSocketSetSocketID( const Socket_t xSocket, void * pvSocketID );
void * pvSocketGetSocketID( const ConstSocket_t xSocket );

Test Steps

/* Read the current value of the SocketID. */
void * id1 = pvSocketGetSocketID( xSocket );

/* Set value of the SocketID. */
int rc = xSocketSetSocketID( xSocket, ( void * ) 0x12345678 );

/* Read the current value of the SocketID. */
void * id2 = pvSocketGetSocketID( xSocket );

FreeRTOS_printf( ( "SocketSetSocketID %p -> %p rc = %d", id1, id2, ( int ) rc ) );

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AniruddhaKanhere · 2022-09-12T22:16:00Z

source/include/FreeRTOSIPConfigDefaults.h

+ * The type of this ID is a void *.  Both UDP and TCP sockets have
+ * this ID. It has a default value of NULL.
+ */
+#ifndef ipconfigUSE_SetSocketID


Do we really need one more config?

Yes why not add it unconditionally. Linkers are smart enough to eliminate dead code. Only MISRA won't like it.
So I also vote to leave out the macro.

Yes why not add it unconditionally. Linkers are smart enough to eliminate dead code. Only MISRA won't like it. So I also vote to leave out the macro.

There is only one thing: all sockets will grown 4 of 8 bytes in size:

#if ( ipconfigUSE_SetSocketID != 0 ) void * pvSocketID; #endif

when the ID pointer is declared unconditionally.

Yes, that is the cost of cleanliness in the code I suppose.
We already have far too many configuration options in my opinion. And the list just keeps growing.
I don't mind adding configs for things which affect the performance or certain characteristics (like timeouts etc) of the stack. But this seems like a bit of an overkill to me.
What do you think @htibosch?

AniruddhaKanhere · 2022-09-12T22:18:53Z

source/FreeRTOS_Sockets.c

+ * @param[in] pvSocketID: The new value for the SocketID.
+ * @return Zero if the socket was valid, otherwise -EINVAL.
+ */
+    BaseType_t xSocketSetSocketID( const Socket_t xSocket,


Seems like this is an API. Why not stick to the convention of starting the name with FreeRTOS_?
Something like FreeRTOS_SetSocketID?

A disadvantage of FreeRTOS_SetSocketID would be that the name doesn't carry the type prefixes, like "x" and "pv".

AniruddhaKanhere · 2022-09-12T22:19:04Z

source/FreeRTOS_Sockets.c

+ *         the socket pointer is not valid or when the ID was not
+ *         yet set.
+ */
+    void * pvSocketGetSocketID( const ConstSocket_t xSocket )


htibosch · 2022-10-01T08:05:44Z

About "Removed the 'ipconfigUSE_SetSocketID' option":
We decided to add the Socket-ID functions unconditionally.

shubnil · 2022-11-03T07:23:39Z

test/unit-test/FreeRTOS_Sockets/FreeRTOS_Sockets_GenericAPI_utest.c

+
+    memset( &xSocket, 0, sizeof( xSocket ) );
+
+    xReturn = xSocketSetSocketID( &xSocket, &AnchorVariable );


What will be the value of the anchor variable here.

shubnil · 2022-11-03T07:27:06Z

source/FreeRTOS_Sockets.c

+{
+    FreeRTOS_Socket_t * pxSocket = ( FreeRTOS_Socket_t * ) xSocket;
+    BaseType_t xReturn = -pdFREERTOS_ERRNO_EINVAL;
+


I have a query here. How are we getting the value of the socket_id. I mean, is it left to the test application to assign a value or will the TCP stack maintain a sequence.

shubnil

Hi, Overall I wanted to understand more on how we are generating the socket-id. Will this be assigned by the test application or will the TCP stack has a way to maintain and assign a socket id.

htibosch · 2022-11-03T13:55:06Z

@shubnil: I will be one of the happy user of this new feature!

My applications encapsulates +TCP sockets into an object. This can be a struct or even a C++ class.

And as you know, the FreeRTOS+TCP library offers several different callbacks ( application hooks ) that are triggered on certain events: on connect, on read, on write etc.
Before this PR, I had to maintain a list of sockets, in order to be able to translate a socket pointer to its encapsulating object.

After this PR, that administration isn't necessary anymore.

The FreeRTOS+TCP library doesn't care about this pointer, it is just stores and reveals it.

How are we getting the value of the socket_id. I mean, is it left to the test application to assign a value or will the TCP stack maintain a sequence.

As you will understand by now, the application builder will manage these pointers.

xReturn = xSocketSetSocketID( &xSocket, &AnchorVariable );
What will be the value of the anchor variable here.

The new feature is storing a pointer. The value of the anchor value will probably an index or a pointer to an instance of a C++ class.

Does that make sense?

shubnil

Thanks, This makes sense.

* IPv4/Single: Add a SocketID to a socket * Change in comment * Applied uncrustify to format the source code * Added a few entries to lexicon.txt * Removed the 'ipconfigUSE_SetSocketID' option * Change to lexicon.txt * Add unit tests for the newly added API Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com>

@brief

* Update mainline to reflect changes after the release. (#563) * Update README.md * Update History.txt * Update version number macros * Update manifest.yml * IPv4/single SAME70 emac race condition (#567) * Implemented Maty's solution * Added a new statistic 'tx_write_fail' * Uncrustify: triggered by comment. Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: GitHub Action <action@github.com> * IPv4/Single: Add a SocketID to a socket (#546) * IPv4/Single: Add a SocketID to a socket * Change in comment * Applied uncrustify to format the source code * Added a few entries to lexicon.txt * Removed the 'ipconfigUSE_SetSocketID' option * Change to lexicon.txt * Add unit tests for the newly added API Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * IPv4/single: SAME70 EMAC buffer sizes (#568) * Implemented Maty's solution * Added a new statistic 'tx_write_fail' * Uncrustify: triggered by comment. * Increase NETWORK_BUFFER_SIZE in order to include the 'ipBUFFER_PADDING' bytes * ICMP checksum calculated manually * Uncrustify: triggered by comment. * Update gmac_SAM.c Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Eliminate some warnings (#578) * Eliminate some warnings related to print statements Authored-by: Pete Bone <pete-pjb@users.noreply.github.com > * Add MISRA justification for use of dynamic memory (#581) * Update deprecated macros in network driver files (#579) * Update deprecated macros in network driver files * Fix typo in RX driver. * Replace #warning with #error on test for deprecated macro. * Fix doxygen check Co-authored-by: PeterB <PeterB@PETE-LT.otg.local> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Fix Network-interface of the Xilinx UltraScale port (#588) The underlying issue was when the port would be used with Jumbo frames. During receives of Jumbo packets the data length was always set incorrectly, which then would cause buffer allocation issues and subsequently corrupted data would be sent to the IP-task. After some inspection in the Xilinx UltraScale port, I found out that when the data length would be set, the wrong mask from the Xilinx Ethernet MAC driver would be used. By using the right mask (XEMACPS_RXBUF_LEN_JUMBO_MASK) when Jumbo Frame support is enabled the issue was resolved * Fix Windows thread calling vTaskSuspendAll / xTaskResumeAll. (#592) Co-authored-by: Jason Carroll <czjaso@amazon.com> * Updated comments for FreeRTOS_select return value (#596) * Updated comments for FreeRTOS_select return value * Updated the function brief for FreeRTOS_select * Uncrustify: triggered by comment. * Updating FreeRTOS_select function @brief * Updated function brief for FreeRTOS_SignalSocket * Uncrustify: triggered by comment. * Update source/FreeRTOS_Sockets.c Co-authored-by: Ubuntu <ubuntu@ip-172-31-22-210.ec2.internal> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * Fixed readme script to build and run unit tests (#644) * Minor warning fixes (#589) * Eliminate compiler unused parameter warning * Eliminate compiler unused variable warnings * Eliminate compiler unused function warning The function pcGetPHIName(...) would be called only in the FreeRTOS_printf message, however FreeRTOS_printf maybe be defined to nothing e.g. release builds, which then the warning would come up * Rework callback setups in the EMAC-driver of the Xilinx UltraScale port The calls to the function XEmacPs_SetHandler would trigger the pedantic warning: "ISO C forbids conversion of object pointer to function pointer type" The reason for this, is that the second parameter of the function XEmacPS_SetHandler is declared as pointer to a void type, but the function "expects" a function pointer, which in setup_isr rightly happens. However IMHO, this is just bad code from the side of Xilinx, as not on all architectures the size of a data pointer is identical to the size of a function pointer, which also is correctly recognised by the compiler. Instead of using the "bad" function XEmacPs_SetHandler, we can set the handlers manually to the EmacPS-instance. * Uncrustify: triggered by comment. * Update source/portable/NetworkInterface/xilinx_ultrascale/x_emacpsif_hw.c Co-authored-by: Paul Bartell <paul.bartell@gmail.com> * Apply suggestions from code review Co-authored-by: Paul Bartell <paul.bartell@gmail.com> * Address comments from reviews Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Paul Bartell <paul.bartell@gmail.com> * Use CBMC XML output to enable VSCode debugger (#673) Prior to this commit, CBMC would emit logging information in plain text format, which does not contain information required for the CBMC VSCode debugger. This commit makes CBMC use XML instead of plain text. Co-authored-by: Mark Tuttle <tuttle@acm.org> * Remove need of token * Use vTaskDelay for sleep in the network-interface of xilinx_ultrascale (#698) The issue here is that, the FreeRTOS IP-task would block all other tasks during PHY-link speed negotiations, as it was using busy waiting. However this is not really ideal. A much more suitable function for such a task would be `vTaskDelay`. * Make sure that a TCP socket is closed only once (#707) * Make sure that a TCP socket is closed only once * Fix failing test cases for FreeRTOS_TCP_IP unit test modules post PR#705 changes * Uncrustify: triggered by comment. * Fix failing test cases for FreeRTOS_TCP_IP unit test modules post PR - 705 changes --------- Co-authored-by: Hein Tibosch <hein_tibosch@yahoo.es> Co-authored-by: GitHub Action <action@github.com> * Remove Dup function HAL_ETH_SetMDIOClockRange. (#711) * Update PR template to include checkbox for ut change (#734) * Main/TCP4 : ACK number in TCP RESET reply to SYN packet (#724) * Main/TCP4 : ACK number in TCP RESET reply to SYN packet * Typo fix * Add unit-test for coverage; Fix ntohl to htonl * Fix unit-test --------- Co-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * #556 Initial Cmake Module definition. (#557) * #556 Initial Cmake Module definition. * Fixing CI builds, rely on pcap. (#556) * Updating tested configurations and minor clean-up of missing network interfaces (#555) * Further clean-up based on testing with build environment. (#555) * Using single definition for libraries everywhere. (#555) * Fixing A_CUSTOM_NETWORK_IF compile option. * Identifying and fixing compile issues. * Adding in additional warnings for GNU to ignore for now. * Fixing formatting issues with uncrustify. * More warnings for GNU used by CI/CD pipeline. * Assuming custom for build tests and using latest freertos-kernel code. Updated readme for how to consume at project level. * Fixing up issues identified in the PR. Making the build_test EXCLUDE_FROM_ALL so only compiled if requested. * Changing to support C89 instead of C99. Renaming tcp_tools to tcp_utilities to mimic the directory. * Using C90 ISO. Fixing compiler warnings. * Fixing non C90 compliant declaration after statement * Separating out CMakeLists so each port is independent. * Updating warning list in code. * Fixed formatting with uncrustify. * Fix failing tests * Fix failing unit-test * Fix a typo. --------- Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> * CMake: Fix GIT_REPOSITORY and GIT_TAG (#742) * Allow use of loopback addresses in IP stack (127.0.0.0/8) (#754) Authored-by: Adam St. Amand <astamand@amazon.com> * Add release candidate automation (#761) This is a minimal subset of release automation which only creates a tag and verifies it. Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> * Add CBMC-running GitHub Action; This commit adds a GitHub Action that runs the CBMC proofs in this repository upon pushes and pull requests * Copy CBMC output directory to CI location This commit ensures that the output directory for CBMC proofs is in the correct location expected by the FreeRTOS CI-CD repository. * rx: Read mac address using FreeRTOS_GetMACAddress() rather than using the defines (#765) * Read mac address using FreeRTOS_GetMACAddress() rather than using the defines --------- Co-authored-by: GitHub Action <action@github.com> * cmake: Remove add_subdirectory( cbmc ) call CBMC proofs cannot currently be run using CMake. fixes #753 * FreeRTOS_IP.h: Fix build error introduced by 55658e1 in FreeRTOS-Kernel * Add Nxp1060 network interface (#774) * Update PR template to include checkbox for ut change * Create NetworkInterface.c * Uncrustify: triggered by comment. * Address PR comments * Uncrustify: triggered by comment. * Update NetworkInterface.c * Uncrustify: triggered by comment. * Update copyright year * Refactor the init function. Add 'brief'. Cleanup. * Uncrustify: triggered by comment. * Update global link status only when the network is quiet * Uncrustify: triggered by comment. * Update copyright yeat * Update the driver to deal with network cable disconnects * Uncrustify: triggered by comment. * Update NetworkInterface.c * Clean up and address PR comments * More cleanup and address PR comments * Uncrustify: triggered by comment. * Empty-Commit * Address issue comments * Uncrustify: triggered by comment. * Empty-Commit to trigger workflow * Remove Full-Duplex restriction * Uncrustify: triggered by comment. * Empty-Commit to trigger workflow --------- Co-authored-by: GitHub Action <action@github.com> * Correct GCC warnings (#798) * Correct GCC warnings Corrects warnings with current GCC flags for GCC 7.5.0. The only suppressed warning pertains to function to object pointer conversion which is required and common for socket callbacks. * PR feedback --------- Co-authored-by: Ubuntu <ubuntu@ip-10-0-137-67.ec2.internal> Co-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com> * Cleanup of NXP1060 network driver (#801) * Update PR template to include checkbox for ut change * Empty-Commit to trigger workflow * Fix issues pointed out in PR comments * Uncrustify: triggered by comment. * Empty-Commit to trigger workflow --------- Co-authored-by: GitHub Action <action@github.com> * Fix Clang warnings (#809) Corrects several warnings from Clang flags for Clang 13. Inspired by @phelter's bug report #558 * uncrustify yml fix (#815) * Add NetworkDown notification to NetworkInterface.c [PR: #671] (#812) * Add NetworkDown notification to EMAC task * Add NetworkDown notification to NetworkInterface.c * Uncrustify: triggered by comment. * Introduce ipconfigSUPPORT_NETWORK_DOWN_EVENT compile flag * Fix formatting * Uncrustify: triggered by comment. --------- Co-authored-by: Filip Oleszek <filip.oleszek@o2.pl> Co-authored-by: zipperowiec <35423392+zipperowiec@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> * Uncrustify bot command fix (#816) * fix uncrustify run command * test uncrustify * Revert "test uncrustify" This reverts commit f660ab4. * Fix uncrustify bot command - disable install prompt (#819) * fix uncrustify run command * test uncrustify * Revert "test uncrustify" This reverts commit f660ab4. * removing apt-get prompt while installing git * Removing deprecated set-output command from uncrustify bot run yml (#820) * fix uncrustify run command * test uncrustify * Revert "test uncrustify" This reverts commit f660ab4. * removing apt-get prompt while installing git * removing the deprecated set-output command from uncrustify bot run yml, use latest git * IPv4/Single: Let send() stop blocking after a connection reset (#561) * IPv4/Single: Let send() stop after a protocol error * Remove token need * Repaired unit-testing * Added the cunftion test_FreeRTOS_send_DisconnectionOccursDuringWait() * Added a comment for unit-test function test_FreeRTOS_send_DisconnectionOccursDuringWait() * Added an item to lexicon.txt * Restored original tcp_utilities * Restored original tcp_utilities, once more --------- Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> Co-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com> * Add logs to print random number generation failure (#908) Add logs to print random number generation failure for better debugging of issue. * Update usage of uint64_t according to C90 standard (#907) Co-authored-by: kar-rahul-aws <118818625+kar-rahul-aws@users.noreply.github.com> * Fix pragma pack in CCS compiler to push/pop (#906) `#pragma pack(1)` would make it so that all structs inserted after pack_struct_start.h was included for the TI arm compiler would be packed, leading to potential unaligned memory access error. Refer: https://www.ti.com/lit/ug/spnu151w/spnu151w.pdf SECTION 5.11.23 * Modified libslirp backend file to cover different libslirp library versions (#929) Authored-by: Xiaodong Li <xiaodonn@amazon.com> * Update according to devIntegration * Update links to point to main directory --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> Co-authored-by: Aniruddha Kanhere <60444055+AniruddhaKanhere@users.noreply.github.com> Co-authored-by: Hein Tibosch <hein_tibosch@yahoo.es> Co-authored-by: Hein Tibosch <hein@htibosch.net> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: alfred gedeon <28123637+alfred2g@users.noreply.github.com> Co-authored-by: Pete Bone <pete-pjb@users.noreply.github.com> Co-authored-by: PeterB <PeterB@PETE-LT.otg.local> Co-authored-by: ChristosZosi <76208460+ChristosZosi@users.noreply.github.com> Co-authored-by: jasonpcarroll <23126711+jasonpcarroll@users.noreply.github.com> Co-authored-by: Jason Carroll <czjaso@amazon.com> Co-authored-by: Tony Josi <117763118+tony-josi-aws@users.noreply.github.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-22-210.ec2.internal> Co-authored-by: Paul Bartell <paul.bartell@gmail.com> Co-authored-by: Kareem Khazem <karkhaz@amazon.com> Co-authored-by: Mark Tuttle <tuttle@acm.org> Co-authored-by: Tony Josi <tonyjosi@amazon.com> Co-authored-by: ActoryOu <jay2002824@gmail.com> Co-authored-by: Nikhil Kamath <110539926+amazonKamath@users.noreply.github.com> Co-authored-by: phelter <paulheltera@gmail.com> Co-authored-by: Adam St. Amand <adam.stamand@gmail.com> Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com> Co-authored-by: sayyadumar <sayyadumar@users.noreply.github.com> Co-authored-by: Paul Bartell <pbartell@amazon.com> Co-authored-by: Kody Stribrny <89810515+kstribrnAmzn@users.noreply.github.com> Co-authored-by: Ubuntu <ubuntu@ip-10-0-137-67.ec2.internal> Co-authored-by: Filip Oleszek <filip.oleszek@o2.pl> Co-authored-by: zipperowiec <35423392+zipperowiec@users.noreply.github.com> Co-authored-by: kar-rahul-aws <118818625+kar-rahul-aws@users.noreply.github.com> Co-authored-by: Rahul Arasikere <arasikere.rahul@gmail.com> Co-authored-by: Xiaodong Li <85011700+ChaiTowKway@users.noreply.github.com>

Hein Tibosch added 2 commits September 2, 2022 14:04

IPv4/Single: Add a SocketID to a socket

17fc154

Change in comment

05919a9

htibosch requested a review from a team as a code owner September 2, 2022 06:26

Hein Tibosch added 2 commits September 2, 2022 15:24

Applied uncrustify to format the source code

8c57056

Added a few entries to lexicon.txt

40dec17

htibosch mentioned this pull request Sep 2, 2022

[Feature Request] Add vTimerSetTimerID/pvTimerGetTimerID equivalents for sockets. #543

Closed

AniruddhaKanhere requested changes Sep 12, 2022

View reviewed changes

alfred2g and others added 4 commits September 17, 2022 17:57

Merge branch 'main' into IPv4_single_Add_SocketSetSocketID

936b143

Merge branch 'main' into IPv4_single_Add_SocketSetSocketID

2a6ff39

Merge branch 'FreeRTOS:main' into IPv4_single_Add_SocketSetSocketID

2ca2401

Removed the 'ipconfigUSE_SetSocketID' option

1e5ac85

Hein Tibosch and others added 3 commits October 27, 2022 12:29

Change to lexicon.txt

986c5aa

Merge branch 'main' into IPv4_single_Add_SocketSetSocketID

bfd9819

Add unit tests for the newly added API

8d2b49f

AniruddhaKanhere approved these changes Nov 3, 2022

View reviewed changes

shubnil reviewed Nov 3, 2022

View reviewed changes

shubnil approved these changes Nov 3, 2022

View reviewed changes

Merge branch 'main' into IPv4_single_Add_SocketSetSocketID

1513593

AniruddhaKanhere merged commit ed04dc7 into FreeRTOS:main Nov 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IPv4/Single: Add a SocketID to a socket #546

IPv4/Single: Add a SocketID to a socket #546

htibosch commented Sep 2, 2022

AniruddhaKanhere Sep 12, 2022

htibosch Sep 14, 2022

htibosch Sep 14, 2022

AniruddhaKanhere Sep 30, 2022

AniruddhaKanhere Sep 12, 2022

htibosch Sep 14, 2022

AniruddhaKanhere Sep 12, 2022

htibosch commented Oct 1, 2022

shubnil Nov 3, 2022

shubnil Nov 3, 2022

shubnil left a comment

htibosch commented Nov 3, 2022

shubnil left a comment


		memset( &xSocket, 0, sizeof( xSocket ) );

		xReturn = xSocketSetSocketID( &xSocket, &AnchorVariable );

IPv4/Single: Add a SocketID to a socket #546

IPv4/Single: Add a SocketID to a socket #546

Conversation

htibosch commented Sep 2, 2022

Description

Test Steps

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

htibosch commented Oct 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubnil left a comment

Choose a reason for hiding this comment

htibosch commented Nov 3, 2022

shubnil left a comment

Choose a reason for hiding this comment