Skip to content

Fixes the build issue with unit tests for IP timers #603

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

tony-josi-aws
Copy link
Member

@tony-josi-aws tony-josi-aws commented Dec 12, 2022

Description

This PR fixes the build issues for the unit tests for IP timers as part of the integration process of IPv4/IPv6.

Test Steps

cmake -S test/unit-test -B test/unit-test/build/
make -C test/unit-test/build/ all

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tony-josi-aws tony-josi-aws requested a review from a team as a code owner December 12, 2022 05:11
Copy link
Contributor

@htibosch htibosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this moment, xNetworkInterfaceOutput() is still called directly (in the "/single" mode).
...
EDIT : the comment here was meant to be placed here at PR #602.

@tony-josi-aws
Copy link
Member Author

/bot run uncrustify

@moninom1
Copy link
Member

Please update the commit message

@tony-josi-aws tony-josi-aws changed the title Ut build fix timers ipv4 Fixes the build issue with unit tests for IP timers Dec 19, 2022
@tony-josi-aws tony-josi-aws merged commit 5754258 into FreeRTOS:dev/IPv6_integration Dec 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants