Skip to content

Fix udp ip failing unit test cases #647

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fix udp ip failing unit test cases #647

merged 4 commits into from
Jan 6, 2023

Conversation

tony-josi-aws
Copy link
Member

@tony-josi-aws tony-josi-aws commented Dec 22, 2022 •
edited
Loading

Fixes UDP IP failing unit tests cases wrt IPv6 changes

Description

This PR fixes the failing test cases for the UDP IP unit tests.

Source file changes:

  • source/FreeRTOS_UDP_IP.c:
    Removed return value variable for function calls that doesn’t return anything
    Added return value for the functions that returns value.

Test Steps

cmake -S test/unit-test -B test/unit-test/build/ 
make -C test/unit-test/build/ all 
cd test/unit-test/build/
ctest -E system --output-on-failure --verbose

Related Issue

Failing test cases

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tony-josi-aws tony-josi-aws requested a review from a team as a code owner December 22, 2022 09:13
@tony-josi-aws tony-josi-aws changed the title Fix udp ip test cases Fix udp ip failing unit test cases Dec 22, 2022
moninom1
moninom1 reviewed Dec 22, 2022
View reviewed changes
test/unit-test/FreeRTOS_UDP_IP/FreeRTOS_UDP_IP_stubs.c Outdated
// */
// void vProcessGeneratedUDPPacket_IPv4( NetworkBufferDescriptor_t * const pxNetworkBuffer )
// {
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need them? Can they be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need them, updated

@tony-josi-aws tony-josi-aws merged commit 5ff68c7 into FreeRTOS:dev/IPv6_integration Jan 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@moninom1 moninom1 moninom1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tony-josi-aws @moninom1