Fix failing test cases for DNS unit tests #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FreeRTOS-Plus-TCP into fix_dns_parser_test_cases
moninom1
reviewed
Jan 6, 2023
source/FreeRTOS_DNS.c
Outdated
| pxEndPoint = prvFillSockAddress( &xAddress, pcHostName ); | ||
|
|
||
| xDNS_IP_Preference = xDNS_IP_Preference_Temp; |
There was a problem hiding this comment.
Thought of restoring back the xDNS_IP_Preference (if it was something else before) after we are done with the function call. Maybe we can remove that as xDNS_IP_Preference is not used anywhere else.
moninom1
approved these changes
Jan 6, 2023
shubnil
approved these changes
Jan 6, 2023
moninom1
approved these changes
Jan 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the failing test cases for DNS unit tests which were failing after the IPv6 integration changes.
NOTE: The unit test:
test_CreateSocket_bind_failfrom DNS_Networking unit test module has been removed as its not relevant to theDNS_CreateSocketfunction after IPv6 integration changes. The flow of binding is validated in a different test case (as part of the test cases forFreeRTOS_gethostbyname) instead.Test Steps
Related Issue
DNS unit test cases were failing due to the changes in the source code as part of the IPv6 integration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.