Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: stop using previously disabled frontend extender #31

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

SychO9
Copy link
Contributor

@SychO9 SychO9 commented Mar 10, 2023

Surprisingly it seems like this is old enough that it used to use a frontend extender from back when they still kind of worked.
This fails in v1.7

@imorland imorland merged commit ea39e08 into FriendsOfFlarum:master Mar 11, 2023
@SKevo18
Copy link

SKevo18 commented Mar 11, 2023

FYI this change seems to produce the following error:

image

@SychO9 SychO9 deleted the patch-1 branch March 11, 2023 17:25
@SychO9
Copy link
Contributor Author

SychO9 commented Mar 11, 2023

probably because the tag allows it to run on a 1.6.0 instance, you can restrict the version to no more than 1.1.0 for those still on 1.6

@SKevo18
Copy link

SKevo18 commented Mar 11, 2023

Ah sorry, should've shared PHP Flarum info (and probably moved it to a new issue at this point):

Flarum core: 1.7.0
PHP version: 8.1.2-1ubuntu2.11
MySQL version: 10.9.3-MariaDB-1:10.9.3+maria~ubu2204
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, exif, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Zend OPcache
+-----------------------------------+---------+--------+
| Flarum Extensions                 |         |        |
+-----------------------------------+---------+--------+
| ID                                | Version | Commit |
+-----------------------------------+---------+--------+
| flarum-flags                      | v1.7.0  |        |
| flarum-likes                      | v1.7.0  |        |
| flarum-suspend                    | v1.7.0  |        |
| flarum-approval                   | v1.7.0  |        |
| flarum-tags                       | v1.7.1  |        |
| antoinefr-money                   | v1.2.0  |        |
| flarum-markdown                   | v1.7.0  |        |
| flarum-sticky                     | v1.7.0  |        |
| flarum-nicknames                  | v1.7.0  |        |
| flarum-lock                       | v1.7.0  |        |
| afrux-forum-widgets-core          | v0.1.7  |        |
| nearata-#-confirm-password   | v3.0.1  |        |
| fof-spamblock                     | 1.1.0   |        |
| fof-pages                         | 1.0.4   |        |
| fof-impersonate                   | 1.1.0   |        |
| fof-byobu                         | 1.1.8   |        |
| ziiven-money-transfer             | v0.2.5  |        |
| zerosonesfun-direct-links         | 3.1     |        |
| zerosonesfun-bbcode-button        | 1.1.3   |        |
| v17development-seo                | v1.8.0  |        |
| therealsujitk-gifs                | v4.1.1  |        |
| the-turk-flamoji                  | 1.0.4   |        |
| sycho-profile-cover               | v1.3.3  |        |
| sycho-move-posts                  | v0.1.7  |        |
| ramesh-dada-bbcode-alerts         | 6.21    |        |
| nearata-embed-video               | v3.2.1  |        |
| kilowhat-audit-free               | 1.6.0   |        |
| justoverclock-welcomebox          | 1.3.8   |        |
| justoverclock-username-blacklist  | 0.1.0   |        |
| justoverclock-purify              | 0.1.7   |        |
| justoverclock-hot-discussions     | 0.1.2   |        |
| justoverclock-hashtag             | 1.0.1   |        |
| justoverclock-feedback            | 0.1.9   |        |
| justoverclock-custom-html-widget  | 0.1.4   |        |
| justoverclock-contactme           | 0.2.3   |        |
| ianm-synopsis                     | 1.2.2   |        |
| ianm-html-head                    | 1.1.0   |        |
| glowingblue-password-strength     | 3.1.0   |        |
| fof-username-request              | 1.1.1   |        |
| fof-user-directory                | 1.2.3   |        |
| fof-user-bio                      | 1.1.1   |        |
| fof-upload                        | 1.2.3   |        |
| fof-terms                         | 1.2.0   |        |
| fof-stopforumspam                 | 1.2.3   |        |
| fof-socialprofile                 | 1.1.4   |        |
| fof-sitemap                       | 2.0.1   |        |
| fof-share-social                  | 1.1.2   |        |
| fof-secure-https                  | 1.1.0   |        |
| fof-reactions                     | 1.1.5   |        |
| fof-polls                         | 1.3.0   |        |
| fof-oauth                         | 1.3.0   |        |
| fof-nightmode                     | 1.5.1   |        |
| fof-moderator-notes               | 1.1.1   |        |
| fof-links                         | 1.1.3   |        |
| fof-ignore-users                  | 1.1.0   |        |
| fof-html-errors                   | 1.1.0   |        |
| fof-formatting                    | 1.0.2   |        |
| fof-filter                        | 1.1.2   |        |
| fof-drafts                        | 1.2.2   |        |
| fof-doorman                       | 1.1.1   |        |
| fof-disposable-emails             | 1.0.0   |        |
| fof-discussion-thumbnail          | 1.1.0   |        |
| fof-default-user-preferences      | 1.2.0   |        |
| fof-cookie-consent                | 1.1.1   |        |
| fof-best-answer                   | 1.2.4   |        |
| fof-ban-ips                       | 1.0.3   |        |
| fof-analytics                     | 1.1.0   |        |
| flarum-statistics                 | v1.7.0  |        |
| flarum-pusher                     | v1.7.0  |        |
| flarum-mentions                   | v1.7.0  |        |
| flarum-lang-italian               | 1.10.0  |        |
| flarum-embed                      | v1.7.0  |        |
| flarum-bbcode                     | v1.7.0  |        |
| flarum-akismet                    | v1.7.0  |        |
| ffans-clipboardjs                 | v1.0.0  |        |
| davwheat-custom-sidenav-links     | 1.0.1   |        |
| datlechin-#-button           | v0.1.1  |        |
| datlechin-more-discussions        | v0.1.0  |        |
| datlechin-keyboard-shortcuts      | v0.1.1  |        |
| clarkwinkelmann-shadow-ban        | 1.1.0   |        |
| clarkwinkelmann-group-list        | 1.0.0   |        |
| clarkwinkelmann-group-invitation  | 1.0.2   |        |
| clarkwinkelmann-create-user-modal | 1.3.1   |        |
| clarkwinkelmann-circle-groups     | 1.0.1   |        |
| clarkwinkelmann-author-change     | 1.0.3   |        |
| blomstra-fontawesome              | 0.1.5   |        |
| askvortsov-pwa                    | v3.1.3  |        |
| askvortsov-discussion-templates   | v0.8.3  |        |
| askvortsov-categories             | v3.0.8  |        |
| afrux-top-posters-widget          | v0.1.4  |        |
| afrux-news-widget                 | v0.1.1  |        |
| acpl-mobile-tab                   | 1.1.1   |        |
+-----------------------------------+---------+--------+
Base URL: https://forumname.freeflarum.com
Installation path: /mnt/data-new/host/forumname
Queue driver: sync
Session driver: file
Scheduler status: Inactive
Mail driver: smtp
Debug mode: off

The error message:

index.js:16 Uncaught TypeError: Cannot read properties of undefined (reading 'Store')
    at index.js:16:28
    at forum.js?v=80371705:2608:8268
    at forum.js?v=80371705:2608:8289

The problem seems to be happening on a v1.7.0 instance, with cache cleared and database migrated.
The issue seems to cause FoF Links to not render at all, if that helps. Maybe it's incompatible with that extension?

Edit: it seems to cause issues in other extensions as well (https://discuss.flarum.org/d/7585/4155)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants