Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changing passwords when logged in is impossible with this plugin #50

Open
Flole998 opened this issue Mar 7, 2024 · 8 comments · May be fixed by #51
Open

Changing passwords when logged in is impossible with this plugin #50

Flole998 opened this issue Mar 7, 2024 · 8 comments · May be fixed by #51
Labels
bug Something isn't working

Comments

@Flole998
Copy link

Flole998 commented Mar 7, 2024

Hi everyone, I am having an issue with the recaptcha plugin and I already identified the issue in the sourcecode. The issue is, that when I am logged in and I want to change my password, Flarum basically does a password reset. However, that password reset needs a recaptcha when the plugin is active. The "bad" validator is added in

if ($flarumValidator instanceof ForgotPasswordValidator && $this->settings->get('fof-recaptcha.forgot')) {
$validator->addRules([
'g-recaptcha-response' => ['required', 'recaptcha'],
. That needs to be changed so the validator is only added if there is no user logged in currently, or the captcha needs to be added to the ChangePasswordModal.

@Flole998 Flole998 added the bug Something isn't working label Mar 7, 2024
Flole998 added a commit to Flole998/recaptcha that referenced this issue Mar 7, 2024
@Flole998 Flole998 linked a pull request Mar 7, 2024 that will close this issue
@giuliomoro
Copy link

giuliomoro commented Sep 9, 2024

+ 1 . @davwheat @dsevillamartin (tagging you because you have the most recent commits on the repo) can you have a look ? There's a pending PR #51 for this.

@RickvanLoo
Copy link

PR #51 is an important bugfix. Currently users are complaining that they cannot reset their passwords and get a red "The g-recaptcha-response field is required.' modal. We cannot really do without this plugin as we've had issues with bots creating accounts before.
Is this plugin still maintained?

@Flole998
Copy link
Author

Flole998 commented Feb 5, 2025

Use the cloudflare turnstile plugin, that one works.

@giuliomoro
Copy link

giuliomoro commented Feb 5, 2025

Fwiw, I have both turnstile and recaptcha enabled and yet get in excess of 10 bot posts per day alongside several more bot registration and honestly I am pretty fed up. Anyone else having similar issues? Anyone in the position of making comparisons with bot detection on other forum software (e.g.: Discourse)?

@RickvanLoo
Copy link

Use the cloudflare turnstile plugin, that one works.

You mean the Blomstra one? https://discuss.flarum.org/d/31790-blomstra-turnstile
That one is unfortunately officially abandoned. I'll check it out but I think it's quite problematic that the only captcha solutions for Flarum have no maintainers...

@Flole998
Copy link
Author

Flole998 commented Feb 5, 2025

Actually nevermind, it is showing up but not working at all. You can just login without solving the captcha (if you want to test: Use the tor browser, it should require manual intervention or just fail straight away).

@RickvanLoo
Copy link

Actually nevermind, it is showing up but not working at all. You can just login without solving the captcha (if you want to test: Use the tor browser, it should require manual intervention or just fail straight away).

Given that's not clear from a user perspective, and the plugin pretends to "work" that means that the blomsta plugin is outright dangerous by now and should be archived/removed.

@giuliomoro
Copy link

giuliomoro commented Feb 6, 2025

See blomstra/flarum-ext-turnstile#4

and

https://discuss.flarum.org/d/31790-blomstra-turnstile/43

Turnstile is broken and not maintained.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants