-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add storefront implementation #10
base: main
Are you sure you want to change the base?
add storefront implementation #10
Conversation
da46b34
to
68e6627
Compare
68e6627
to
f64ceb5
Compare
I have set
but still see tracesSampleRate: 0.1,
replaysSessionSampleRate: 0.1, |
], | ||
'tracing' => [ | ||
'enabled' => $isPerformanceTracingEnabled, | ||
'sample_rate' => is_float($tracingSample) ? $tracingSample : 0.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'sample_rate' => is_float($tracingSample) ? $tracingSample : 0.1, | |
'sample_rate' => is_numeric($tracingSample) ? $tracingSample : 0.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #10 (comment)
'javascript_src' => sprintf("https://browser.sentry-cdn.com/%s/%s", $jsSdkVersion, $jsFile), | ||
'replay_recording' => [ | ||
'enabled' => $isReplayRecordingEnabled, | ||
'sample_rate' => is_float($replaySample) ? $replaySample : 0.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'sample_rate' => is_float($replaySample) ? $replaySample : 0.1, | |
'sample_rate' => is_numeric($replaySample) ? $replaySample : 0.1, |
@shyim do you have comments on this PR? @rommelfreddy Do you want to polish the PR (fix the phpstan issues)? If you don't have time, I believe I can fix the PHPstan issues. Did some tests and it works well for me - would love to see this merged. |
reminder |
this pr will add error-tracking/tracing and replay for storefront.
sadly it is required to change the bundle-type to a shopware-bundle. If you have another idea get the templates into the inheritance of rendering, please let me now.