Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test on PHP 8.0 #1642

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Test on PHP 8.0 #1642

merged 1 commit into from
Mar 12, 2021

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Sep 12, 2020

@deguif deguif force-pushed the php-8-test branch 2 times, most recently from cf52c06 to 99b04f7 Compare September 12, 2020 09:59
@deguif deguif changed the title Test on PHP 8 Test on PHP 8.0 Sep 12, 2020
@giovannialbero1992
Copy link
Contributor

@deguif I opened a PR here elastic/elasticsearch-php#1063 for elasticsearch-php

@deguif
Copy link
Contributor Author

deguif commented Sep 16, 2020

Nice, I didn't have time to do it ;)

@XWB XWB mentioned this pull request Dec 1, 2020
@curry684
Copy link

As elastic/elasticsearch-php#1063 was merged, when is FOSElastica going up?

@XWB
Copy link
Member

XWB commented Dec 16, 2020

I think @deguif will have to update this PR and test against PHP 8 to see if there are any errors.

@deguif
Copy link
Contributor Author

deguif commented Dec 16, 2020

Yes, this one was merged too: elastic/elasticsearch-php#1075
I'm waiting an official release to update this PR ;)

@bogdandubyk
Copy link

any updates, when we can expect PHP8 support? :)

@deguif
Copy link
Contributor Author

deguif commented Feb 2, 2021

@bogdandubyk still no official release on https://github.com/elastic/elasticsearch-php for PHP 8.0 support which blocks https://github.com/ruflin/Elastica and this project.

@jleehr
Copy link

jleehr commented Feb 10, 2021

elastic/elasticsearch-php gets PHP 8 support for version 7.11, which will be released soon.
See elastic/elasticsearch-php#1083 (comment)

@deguif
Copy link
Contributor Author

deguif commented Feb 11, 2021

I'm preparing official release on ruflin/elastica now that elastic/elasticsearch-php 7.11.0 was released.

@darthf1
Copy link
Contributor

darthf1 commented Mar 11, 2021

Hi @deguif is it possible to merge this and allow php 8?

@XWB XWB merged commit e25b3c7 into FriendsOfSymfony:master Mar 12, 2021
@deguif deguif deleted the php-8-test branch March 12, 2021 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants