Remove notice appeared on php 7.4 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll in sfForm.class.php on line 947`
|
Duplicates #227. |
alquerci
approved these changes
May 6, 2020
Only by name. My PR is fixing root issue (algorithm error in the code), while mentioned PR fixes only a symptom (i.e. removes a warning) 😉 |
|
The merger will took the decision, as the same decision was recommended on code review. cc @valepu |
|
Yes I agreed in the discussion this is the best way. I should've probably just closed my pull request |
valepu
approved these changes
May 7, 2020
valepu
approved these changes
May 7, 2020
|
Same as #228, why does that notice never popup on Travis? |
|
@j0k3r see #227 (comment) In short the error reporting configuration. |
|
@alquerci but I can't find where that level is defined. Do you? |
|
@j0k3r me too, searched but not found. So need an investigation. |
|
Can't find it and don't have time to work on it. |
j0k3r
approved these changes
Jun 8, 2020
|
@j0k3r me too, no time. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Notice: Trying to access array offset on value of type null in sfForm.class.php on line 947`