Compat for Swiftmailer 6 but preserve compatibility with Swiftmailer 5.

[thirsch]

This pr is the follow up for #237. Thanks for your review.

[alquerci]

LGTM but let's not forgot to add tests.

For that I suggest to add one job with SwiftMailer version 6 on travis build.

Do you know enough about travis-ci to do that change or you need help?

PS: you can update the same PR by just push another commit to feature/swiftmailer-6-compat-2.

[thirsch]

LGTM but let's not forgot to add tests.

For that I suggest to add one job with SwiftMailer version 6 on travis build.

Do you know enough about travis-ci to do that change or you need help?

PS: you can update the same PR by just push another commit to feature/swiftmailer-6-compat-2.

Thanks for your re-review. I've not done a project on travis so far and help would be much appreciated. At the moment we are installing swiftmailer 5 if the tests are running on PHP < 7 and if we are running on PHP >= 7, it is already installing swiftmailer 6. Any specific point to test or would that be sufficient?

[alquerci]

Any specific point to test or would that be sufficient?

That's sufficient.

To execute the current test for each swift version
https://github.com/FriendsOfSymfony1/symfony1/blob/6185ffc7f31bfe68d37690b4d3533a5ab69279dd/test/unit/mailer/sfMailerTest.php

help would be much appreciated

I will try to tackle this this week-end.

A trade-off here is to install swift version 6 on before install then revert the commit when travis build is done.
The next step will be to add a dedicated job.

[thirsch]

help would be much appreciated

I will try to tackle this this week-end.

Thanks

A trade-off here is to install swift version 6 on before install then revert the commit when travis build is done.
The next step will be to add a dedicated job.

At the moment composer install during the build process already installs swift version 5 on PHP < 7 and swift version 6 on PHP >= 7. Or do you plan do somehow force swift version 5 on PHP > 7 as an additional test for version 6?

[alquerci]

At the moment composer install during the build process already installs swift version 5 on PHP < 7 and swift version 6 on PHP >= 7. Or do you plan do somehow force swift version 5 on PHP > 7 as an additional test for version 6?

Ha, got it now (refreshing my memory => because composer install the latest possible version).

In that case I think that's enough except there is a bug on lowest versions.
Using composer update --prefer-lowest => ✔️

[mentalstring]

LGTM 👍

[thePanz]

Thank you @thirsch , merged

[thePanz]

Found out that lib/plugins/sfDoctrinePlugin/lib/mailer/Swift_DoctrineSpool.class.php class still references to Swift_Mime_Message, which is not around if the application installs SwiftMailer v6.

Any hints @thirsch ?

[thirsch]

Good catch, @thePanz. We could do the same as in this pr by removing the type from the method signature and add both types to the phpdoc. I can create a pr for it, if you like.

[thePanz]

Good catch, @thePanz. We could do the same as in this pr by removing the type from the method signature and add both types to the phpdoc. I can create a pr for it, if you like.

Yes, please go ahead 👍
the tricky part: the interface is from the SwiftMailer itself, IIRC :)

[thirsch]

Yes, please go ahead 👍 the tricky part: the interface is from the SwiftMailer itself, IIRC :)

Ok, got it. We might be able to fix it with the solution I had before just removing the type. The pr is still available, so please have a look at it: https://github.com/FriendsOfSymfony1/symfony1/pull/237/files#diff-ab78635a7285fe1eca9b5c7fad605d21d3f09ccd2737c0af6bbf7022f66f95a7

As I'm on vacation next week, it will take a few days to come up with a proposal.