Fixed a few more php 8 issues #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The testsuite is currently not working under Apple M1. I'll get myself a amd64 test machine and come back with a fix. |
Tests are running fine on my local machine and over in the fork of the repository. Any idea, why it crashed here? Can you re-run them manually or do I have to push a change to the branch to start them again? |
thirsch
force-pushed
the
feature/more-php-8.1-fixes
branch
from
31eb7a7 to
d126433
Compare
thirsch
force-pushed
the
feature/more-php-8.1-fixes
branch
from
d126433 to
8b81a56
Compare
done |
|
@thirsch were you able to get tests to run on Mac M1? |
Sorry for my late reply. To be honest, I don't remember. ;-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the current release, we have found the following issues under php 8.1