Fix PHP8.1 sfForm - Unsupported operand types: array + null on sfForm #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thirsch
reviewed
Feb 14, 2023
lib/form/sfForm.class.php
Outdated
| @@ -316,7 +316,7 @@ public function isBound() | |||
| */ | |||
| public function updateValues(array $values) | |||
| { | |||
| $this->values = $values + $this->values; | |||
| $this->values = $values + (isset($this->values) ? $this->values : array()); | |||
There was a problem hiding this comment.
How about setting the initial value of $values to array()?
symfony1/lib/form/sfForm.class.php
Line 48 in c8cadb4
thePanz
force-pushed
the
fix_sfform_php8.1
branch
from
c8cadb4 to
7f4be9b
Compare
|
@Tybaze I updated this PR according to the comments (and rebased on the latest |
thePanz
approved these changes
Jan 3, 2024
thePanz
requested review from
thirsch and
connorhu
and removed request for
thirsch
thePanz
force-pushed
the
fix_sfform_php8.1
branch
from
7f4be9b to
accb231
Compare
connorhu
approved these changes
Jan 3, 2024
thePanz
force-pushed
the
fix_sfform_php8.1
branch
from
accb231 to
141129d
Compare
…::updateValues()
Avoid error:
Fatal error: Uncaught TypeError: Unsupported operand types: array + null in lib\form\sfForm.class.php:319
Step to reproduce :
$form = new sfForm();
$form->updateValues(array('foo' => 'value'));
PHP 5.3 coding style
May use sfForm::getValues(), but as sfForm::updateValues() is a hack, it could be used before bind ($this->isBound = true);
thePanz
force-pushed
the
fix_sfform_php8.1
branch
from
141129d to
8d77417
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHP8.1 sfForm - Unsupported operand types: array + null on sfForm::updateValues()
Avoid error :
Fatal error: Uncaught TypeError: Unsupported operand types: array + null in lib\form\sfForm.class.php:319
Step to reproduce :
$form = new sfForm();
$form->updateValues(array('foo' => 'value'));
PHP 5.3 coding style
May use sfForm::getValues(), but as sfForm::updateValues() is a hack, it could be used before bind ($this->isBound = true);