Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

minor fix: remove fourth argument #308

Merged
merged 1 commit into from
Jan 17, 2024
Merged

minor fix: remove fourth argument #308

merged 1 commit into from
Jan 17, 2024

Conversation

connorhu
Copy link
Collaborator

There is no fourth argument. Nice catch phpstan!

@thePanz thePanz self-requested a review January 17, 2024 23:30
@thePanz
Copy link
Member

thePanz commented Jan 17, 2024

Thanks @connorhu!

Do we have a phpstan integration planned? that would be great to have it in the pipeline too
IIRC the last time I tried to enable it, it crashed with some methods overrides where the return type changed from a value to an array

@thePanz thePanz merged commit 9d26d67 into master Jan 17, 2024
@thePanz thePanz deleted the connorhu-patch-1 branch January 17, 2024 23:32
@connorhu
Copy link
Collaborator Author

@thePanz At this time we have 800+ errors at level 9 (Which seems a lot, but in a much smaller project I last found 3000). I can see the sense of making a distribution stan config, but running it in a workspace is yet too early. I plan to run it locally sometimes and fix any bugs that arise.

@mentalstring
Copy link
Contributor

I had a go at some point and also hit some internal error crashes.

@connorhu Could you share here what phpstan version and config you are using?

@connorhu
Copy link
Collaborator Author

@mentalstring master...connorhu:symfony1:feature/stanconfig It needs work because it stops after 50 internal errors. Generated classes are missing.

@connorhu
Copy link
Collaborator Author

oh. 24658 errors if i setup properly. nice.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants