Fix phpstan errors

lib/cache/sfAPCuCache.class.php

@@ -102,6 +102,8 @@ public function clean($mode = sfCache::ALL)
         if (sfCache::ALL === $mode) {
             return apcu_clear_cache();
         }
+
+        return true;
     }
 
     /**
@@ -139,24 +141,26 @@ public function removePattern($pattern)
 
         $infos = apcu_cache_info();
         if (!is_array($infos['cache_list'])) {
-            return;
+            return true;
         }
 
-        $regexp = self::patternToRegexp($this->getOption('prefix').$pattern);
+        $regexp = $this->patternToRegexp($this->getOption('prefix').$pattern);
 
         foreach ($infos['cache_list'] as $info) {
             if (preg_match($regexp, $info['info'])) {
                 apcu_delete($info['info']);
             }
         }
+
+        return true;
     }
 
     /**
      * Gets the cache info.
      *
      * @param string $key The cache key
      *
-     * @return string
+     * @return string|false|array
      */
     protected function getCacheInfo($key)
     {
@@ -177,6 +181,13 @@ protected function getCacheInfo($key)
         return null;
     }
 
+    /**
+     * @param string $key
+     *
+     * @param-out bool $success
+     *
+     * @return false|mixed
+     */
     private function fetch($key, &$success)
     {
         $has = null;

lib/cache/sfFileCache.class.php

@@ -122,6 +122,8 @@ public function removePattern($pattern)
                 @unlink($path);
             }
         }
+
+        return true;
     }
 
     /**

lib/cache/sfMemcacheCache.class.php

@@ -145,6 +145,8 @@ public function clean($mode = sfCache::ALL)
         if (sfCache::ALL === $mode) {
             return $this->memcache->flush();
         }
+
+        return true;
     }
 
     /**
@@ -188,6 +190,8 @@ public function removePattern($pattern)
                 $this->remove(substr($key, strlen($this->getOption('prefix'))));
             }
         }
+
+        return true;
     }
 
     /**

lib/task/app/sfAppRoutesTask.class.php

@@ -47,6 +47,8 @@ protected function execute($arguments = [], $options = [])
 
         // display
         $arguments['name'] ? $this->outputRoute($arguments['application'], $arguments['name']) : $this->outputRoutes($arguments['application']);
+
+        return 0;
     }
 
     protected function outputRoutes($application)

lib/task/cache/sfCacheClearTask.class.php

@@ -154,6 +154,8 @@ protected function execute($arguments = [], $options = [])
         if (null === $options['app'] && 'all' == $options['type']) {
             $this->getFilesystem()->remove(sfFinder::type('file')->discard('.*')->in(sfConfig::get('sf_cache_dir')));
         }
+
+        return 0;
     }
 
     protected function getClearCacheMethod($type)

lib/task/configure/sfConfigureAuthorTask.class.php

@@ -63,5 +63,7 @@ protected function execute($arguments = [], $options = [])
         }
 
         file_put_contents($file, $ini);
+
+        return 0;
     }
 }

lib/task/generator/sfGenerateAppTask.class.php

@@ -153,5 +153,7 @@ protected function execute($arguments = [], $options = [])
 
         // Create test dir
         $this->getFilesystem()->mkdirs(sfConfig::get('sf_test_dir').'/functional/'.$app);
+
+        return 0;
     }
 }

lib/task/generator/sfGenerateModuleTask.class.php

@@ -104,5 +104,7 @@ protected function execute($arguments = [], $options = [])
         // customize php and yml files
         $finder = sfFinder::type('file')->name('*.php', '*.yml');
         $this->getFilesystem()->replaceTokens($finder->in($moduleDir), '##', '##', $constants);
+
+        return 0;
     }
 }

lib/task/generator/sfGenerateProjectTask.class.php

@@ -137,6 +137,8 @@ protected function execute($arguments = [], $options = [])
         $fixPerms->run();
 
         $this->replaceTokens();
+
+        return 0;
     }
 
     protected function canRunInstaller($installer)

lib/task/generator/sfGenerateTaskTask.class.php

@@ -178,5 +178,7 @@ protected function execute(\$arguments = array(), \$options = array())
 
         $this->logSection('task', sprintf('Creating "%s" task file', $taskFile));
         file_put_contents($taskFile, $content);
+
+        return 0;
     }
 }

lib/task/help/sfHelpTask.class.php

@@ -57,6 +57,8 @@ protected function execute($arguments = [], $options = [])
         } else {
             $this->outputAsText($task);
         }
+
+        return 0;
     }
 
     protected function outputAsText(sfTask $task)

lib/task/help/sfListTask.class.php

@@ -73,6 +73,8 @@ protected function execute($arguments = [], $options = [])
         } else {
             $this->outputAsText($arguments['namespace'], $tasks);
         }
+
+        return 0;
     }
 
     protected function outputAsText($namespace, $tasks)

lib/task/i18n/sfI18nExtractTask.class.php

@@ -66,6 +66,8 @@ public function execute($arguments = [], $options = [])
 
             $extract->deleteOldMessages();
         }
+
+        return 0;
     }
 
     /**

lib/task/i18n/sfI18nFindTask.class.php

@@ -85,6 +85,8 @@ public function execute($arguments = [], $options = [])
                 $this->log("  {$message}\n");
             }
         }
+
+        return 0;
     }
 
     /**

lib/task/log/sfLogClearTask.class.php

@@ -38,5 +38,7 @@ protected function execute($arguments = [], $options = [])
     {
         $logs = sfFinder::type('file')->in(sfConfig::get('sf_log_dir'));
         $this->getFilesystem()->remove($logs);
+
+        return 0;
     }
 }

lib/task/log/sfLogRotateTask.class.php

@@ -143,5 +143,7 @@ protected function configure()
     protected function execute($arguments = [], $options = [])
     {
         $this->rotate($arguments['application'], $arguments['env'], $options['period'], $options['history'], true);
+
+        return 0;
     }
 }

lib/task/plugin/sfPluginAddChannelTask.class.php

@@ -46,5 +46,7 @@ protected function execute($arguments = [], $options = [])
         $this->logSection('plugin', sprintf('add channel "%s"', $arguments['name']));
 
         $this->getPluginManager()->getEnvironment()->registerChannel($arguments['name']);
+
+        return 0;
     }
 }

lib/task/plugin/sfPluginInstallTask.class.php

@@ -111,5 +111,7 @@ protected function execute($arguments = [], $options = [])
         }
 
         $this->getPluginManager()->installPlugin($arguments['name'], $options);
+
+        return 0;
     }
 }

lib/task/plugin/sfPluginListTask.class.php

@@ -47,5 +47,7 @@ protected function execute($arguments = [], $options = [])
             $alias = $this->getPluginManager()->getEnvironment()->getRegistry()->getChannel($package->getChannel())->getAlias();
             $this->log(sprintf(' %-40s %10s-%-6s %s', $this->formatter->format($package->getPackage(), 'INFO'), $package->getVersion(), $package->getState() ?: null, $this->formatter->format(sprintf('# %s (%s)', $package->getChannel(), $alias), 'COMMENT')));
         }
+
+        return 0;
     }
 }

lib/task/plugin/sfPluginPublishAssetsTask.class.php

@@ -77,6 +77,8 @@ protected function execute($arguments = [], $options = [])
             $this->logSection('plugin', 'Configuring plugin - '.$plugin);
             $this->installPluginAssets($plugin, $pluginConfiguration->getRootDir(), $options['relative']);
         }
+
+        return 0;
     }
 
     /**

lib/task/plugin/sfPluginUninstallTask.class.php

@@ -70,5 +70,7 @@ protected function execute($arguments = [], $options = [])
         $this->logSection('plugin', sprintf('uninstalling plugin "%s"', $arguments['name']));
 
         $this->getPluginManager()->uninstallPlugin($arguments['name'], $options['channel']);
+
+        return 0;
     }
 }

lib/task/plugin/sfPluginUpgradeTask.class.php

@@ -59,5 +59,7 @@ protected function execute($arguments = [], $options = [])
         $this->logSection('plugin', sprintf('upgrading plugin "%s"', $arguments['name']));
 
         $this->getPluginManager()->installPlugin($arguments['name'], $options);
+
+        return 0;
     }
 }

lib/task/project/sfProjectClearControllersTask.class.php

@@ -68,5 +68,7 @@ protected function execute($arguments = [], $options = [])
                 }
             }
         }
+
+        return 0;
     }
 }

lib/task/project/sfProjectDeployTask.class.php

@@ -170,6 +170,8 @@ protected function execute($arguments = [], $options = [])
         $this->getFilesystem()->execute($command, $options['trace'] ? [$this, 'logOutput'] : null, [$this, 'logErrors']);
 
         $this->clearBuffers();
+
+        return 0;
     }
 
     protected function clearBuffers()

lib/task/project/sfProjectDisableTask.class.php

@@ -65,5 +65,7 @@ protected function execute($arguments = [], $options = [])
                 $this->logSection('enable', sprintf('%s [%s] has been DISABLED', $app, $env));
             }
         }
+
+        return 0;
     }
 }

lib/task/project/sfProjectEnableTask.class.php

@@ -70,5 +70,7 @@ protected function execute($arguments = [], $options = [])
                 $this->logSection('enable', sprintf('%s [%s] has been ENABLED', $app, $env));
             }
         }
+
+        return 0;
     }
 }

lib/task/project/sfProjectOptimizeTask.class.php

@@ -90,6 +90,8 @@ protected function execute($arguments = [], $options = [])
         file_put_contents($target, '<?php return '.var_export($data, true).';');
 
         umask($current_umask);
+
+        return 0;
     }
 
     protected function optimizeGetControllerDirs($modules)

lib/task/project/sfProjectPermissionsTask.class.php

@@ -79,7 +79,11 @@ protected function execute($arguments = [], $options = [])
                 ['Permissions on the following file(s) could not be fixed:', ''],
                 array_map(function ($f) { return ' - '.sfDebug::shortenFilePath($f); }, $this->failed)
             ), 'ERROR_LARGE');
+
+            return 1;
         }
+
+        return 0;
     }
 
     /**

lib/task/project/sfProjectSendEmailsTask.class.php

@@ -58,5 +58,7 @@ protected function execute($arguments = [], $options = [])
         $sent = $this->getMailer()->flushQueue();
 
         $this->logSection('project', sprintf('sent %s emails', $sent));
+
+        return 0;
     }
 }

lib/task/project/sfProjectValidateTask.class.php

@@ -66,6 +66,8 @@ protected function execute($arguments = [], $options = [])
 
             $this->log($v->getExplanation());
         }
+
+        return 0;
     }
 
     protected function formatFile($file)

lib/task/sfBaseTask.class.php

@@ -59,6 +59,8 @@ public function checkProjectExists()
         if (!file_exists('symfony')) {
             throw new sfException('You must be in a symfony project directory.');
         }
+
+        return true;
     }
 
     /**
@@ -75,6 +77,8 @@ public function checkAppExists($app)
         if (!is_dir(sfConfig::get('sf_apps_dir').'/'.$app)) {
             throw new sfException(sprintf('Application "%s" does not exist', $app));
         }
+
+        return true;
     }
 
     /**
@@ -92,6 +96,8 @@ public function checkModuleExists($app, $module)
         if (!is_dir(sfConfig::get('sf_apps_dir').'/'.$app.'/modules/'.$module)) {
             throw new sfException(sprintf('Module "%s/%s" does not exist.', $app, $module));
         }
+
+        return true;
     }
 
     /**

lib/task/test/sfTestCoverageTask.class.php

@@ -65,6 +65,8 @@ protected function execute($arguments = [], $options = [])
 
         $coveredFiles = $this->getFiles(sfConfig::get('sf_root_dir').'/'.$arguments['lib_name']);
         $coverage->output($coveredFiles);
+
+        return 0;
     }
 
     protected function getTestHarness($harnessOptions = [])

lib/task/test/sfTestFunctionalTask.class.php

@@ -83,6 +83,8 @@ protected function execute($arguments = [], $options = [])
                 }
             } else {
                 $this->logSection('functional', 'no controller found', null, 'ERROR');
+
+                return 1;
             }
         } else {
             require_once __DIR__.'/sfLimeHarness.class.php';

lib/task/test/sfTestPluginTask.class.php

@@ -67,6 +67,6 @@ protected function execute($arguments = [], $options = [])
         $finder = sfFinder::type('file')->follow_link()->name('*Test.php');
         $h->register($finder->in($h->base_dir));
 
-        $h->run();
+        return $h->run();
     }
 }