Merge pull request ManageIQ#74 from Fryguy/compat_stable_sort_by

Add deprecation warning for Enumerable#stable_sort_by
Fryguy · Jan 31, 2020 · 82af0b7 · 82af0b7
2 parents 37ce32e + 63be5fe
commit 82af0b7
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/lib/more_core_extensions/all.rb b/lib/more_core_extensions/all.rb
@@ -3,6 +3,7 @@
 require 'more_core_extensions/core_ext/array'
 require 'more_core_extensions/core_ext/benchmark'
 require 'more_core_extensions/core_ext/class'
+require 'more_core_extensions/core_ext/enumerable'
 require 'more_core_extensions/core_ext/hash'
 require 'more_core_extensions/core_ext/math'
 require 'more_core_extensions/core_ext/module'

diff --git a/lib/more_core_extensions/core_ext/enumerable.rb b/lib/more_core_extensions/core_ext/enumerable.rb
@@ -0,0 +1 @@
+require 'more_core_extensions/core_ext/enumerable/sorting'
diff --git a/lib/more_core_extensions/core_ext/enumerable/sorting.rb b/lib/more_core_extensions/core_ext/enumerable/sorting.rb
@@ -0,0 +1,15 @@
+module MoreCoreExtensions
+  module StableSorting
+    def self.included(klass)
+      klass.class_eval do
+        # <b>DEPRECATED:</b> Please use <tt>tabular_sort</tt> instead.
+        def stable_sort_by(*args)
+          warn "[DEPRECATION] `stable_sort_by` is deprecated.  Please use `Array#tabular_sort` instead."
+          to_a.tabular_sort(*args)
+        end
+      end
+    end
+  end
+end
+
+Enumerable.send(:include, MoreCoreExtensions::StableSorting)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		require 'more_core_extensions/core_ext/enumerable/sorting'