This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
deps: bump deps. #19
Merged
deps: bump deps. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
approved these changes
Oct 2, 2022
eureka-cpu
reviewed
Oct 2, 2022
| DEFAULT_SPENDABLE_COIN_AMOUNT, | ||
| coin_witness_index, | ||
| ) | ||
| .get_asset_inputs_for_amount(AssetId::default(), 1_000_000, coin_witness_index) |
There was a problem hiding this comment.
Should we be getting rid of the const here?
There was a problem hiding this comment.
I think it is removed from the fuels_core so we need to remove that. See FuelLabs/sway#2896 (comment) for more detail.
There was a problem hiding this comment.
Hm, should we maybe put it behind a local const then for readability? eg const SPENDABLE_COIN_AMOUNT = 1_000_000
There was a problem hiding this comment.
After reading through other PRs I see in some context local consts are used and other times not, up to you @bingcicle !
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swaydependencies to0.24.5fuelsdeps according to Bump a few dependencies sway#2896