Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Increase max ram to 64 MiB #223

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Increase max ram to 64 MiB #223

merged 2 commits into from
Nov 18, 2021

Conversation

adlerjohn
Copy link
Contributor

No description provided.

@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Nov 16, 2021
@adlerjohn adlerjohn self-assigned this Nov 16, 2021
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but shouldn't we increase the maximum mem access as well? As long as the user don't overflow the available memory and pays enough gas, I don't see why to restrict it to a small fraction of the VM memory

@adlerjohn
Copy link
Contributor Author

We should, independently. But that needs to be reworked to differentiate between memory that must be accessed atomically (i.e. hash functions) vs memory that can be accessed one word at a time (i.e. memory clear/copy/eq). So separate PR.

@adlerjohn adlerjohn merged commit 930d153 into master Nov 18, 2021
@adlerjohn adlerjohn deleted the adlerjohn/max_ram_increase branch November 18, 2021 00:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
comp:FVM Component: FuelVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants