Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix pointer register naming #31

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Fix pointer register naming #31

merged 3 commits into from
Jan 27, 2021

Conversation

adlerjohn
Copy link
Contributor

Use more standard naming for "pointer" registers:

  1. frame pointer (above top of call frame, i.e. free stack memory) -> stack pointer
  2. frame pointer previous (above top of previous call frame = start of this call frame) -> frame pointer
  3. Remove heap pointer previous. It's not needed since the previous heap pointer is in the call frame and heap isn't freed anyways.

@adlerjohn adlerjohn self-assigned this Jan 26, 2021
@adlerjohn adlerjohn requested a review from sezna January 26, 2021 19:32
@adlerjohn adlerjohn merged commit 838cb4b into master Jan 27, 2021
@adlerjohn adlerjohn deleted the adlerjohn-fix_pointer_naming branch January 27, 2021 04:10
@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Feb 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sezna sezna sezna approved these changes

Assignees

@adlerjohn adlerjohn

Labels
comp:FVM Component: FuelVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adlerjohn @sezna