Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed owner from input messages #400

Conversation

pixelcircuits
Copy link
Contributor

@pixelcircuits pixelcircuits commented Aug 14, 2022

This PR moves what previously was referred to as the "owner" from input messages into the "recipient" field. This removes redundancy for messages that didn't need a "recipient" field (like a simple ETH bridging). What was previously used in the "recipient" field can simply be placed in the "data" field. This also simplifies messages and makes the calculation of messageId the same for both input and output messages.

Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would like a second set of eyes from @Voxelot or @vlopes11 to confirm.

@Voxelot
Copy link
Member

Voxelot commented Aug 15, 2022

Would it make sense to use owner instead of recipient? That way it's more consistent with our standard UTXO's which use the owner field for specifying TX output recipients.

@pixelcircuits
Copy link
Contributor Author

Would it make sense to use owner instead of recipient? That way it's more consistent with our standard UTXO's which use the owner field for specifying TX output recipients.

I left the term "recipient" because it's currently describing all messages (both input and output). "Owner" doesn't make sense for output messages because it will only ever be addresses. It's kind of it's own separate thing

Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the term "recipient" because it's currently describing all messages (both input and output). "Owner" doesn't make sense for output messages because it will only ever be addresses. It's kind of it's own separate thing

"Recipient" does make sense in the context of "sending and receiving messages". The difference between owner and recipient isn't a big deal and probably not worth bikeshedding.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Simplify InputMessages by making the recipient act as the owner
3 participants