Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Minor enhancement to storage instructions + various nits #432

Merged
merged 6 commits into from
Nov 25, 2022
Merged

Minor enhancement to storage instructions + various nits #432

merged 6 commits into from
Nov 25, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Nov 8, 2022 •
edited
Loading

  • Defined the STATE[..] syntax.
  • Also some minor nits all over the spec.

@mohammadfawaz mohammadfawaz requested review from a user and adlerjohn November 8, 2022 04:21
@mohammadfawaz mohammadfawaz self-assigned this Nov 8, 2022
@mohammadfawaz mohammadfawaz added the comp:FVM Component: FuelVM label Nov 8, 2022
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/enhance_storage_opcodes branch from be64891 to a546b01 Compare November 8, 2022 04:22
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/enhance_storage_opcodes branch from a546b01 to 7947974 Compare November 8, 2022 04:26
@mohammadfawaz mohammadfawaz changed the title Minor enhancement to storage instructions Minor enhancement to storage instructions + various nits Nov 8, 2022
@mohammadfawaz mohammadfawaz force-pushed the mohammadfawaz/enhance_storage_opcodes branch from 2859318 to 9275833 Compare November 8, 2022 04:45
adlerjohn
adlerjohn previously approved these changes Nov 25, 2022
View reviewed changes
xgreenx
xgreenx reviewed Nov 25, 2022
View reviewed changes
Copy link
Contributor

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you did it by the tool, which automatically increases the list's numeral. I think better to use 1. everywhere, but it is up to you.

src/protocol/id/utxo.md Outdated Show resolved Hide resolved
src/protocol/tx_format/transaction.md Outdated Show resolved Hide resolved
src/vm/index.md Outdated Show resolved Hide resolved
src/vm/instruction_set.md Outdated Show resolved Hide resolved
@mohammadfawaz mohammadfawaz merged commit d80a369 into master Nov 25, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/enhance_storage_opcodes branch November 25, 2022 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@Voxelot Voxelot Awaiting requested review from Voxelot

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@mohammadfawaz mohammadfawaz

Labels
comp:FVM Component: FuelVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadfawaz @adlerjohn @xgreenx