Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add feature to check if hex is an account #3307

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

maschad
Copy link
Contributor

@maschad maschad commented Oct 10, 2024

Release notes

In this release, we:

  • Added Provider methods isUserAccount and getAddressType which indicate the type of the hex passed

Summary

We now have two methods on the Provider to check the account type

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 7:07pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 7:07pm

@github-actions github-actions bot added the feat Issue is a feature label Oct 10, 2024
@maschad maschad requested a review from LuizAsFight October 10, 2024 18:01
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #3307 will not alter performance

Comparing mc/feat/add-endpoint-for-checking-user-accounts (54f85e5) with master (d1b4505)

Summary

✅ 18 untouched benchmarks

@maschad maschad requested a review from Torres-ssf October 10, 2024 18:07
Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3307-20241010181303

Torres-ssf
Torres-ssf previously approved these changes Oct 10, 2024
This reverts commit 1aea14c.
.github/workflows/pr-release.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.02%(-0.11%) 69.92%(-0.27%) 75.01%(-0.12%) 76.15%(-0.1%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.8%
(-1.95%)
60.95%
(-3.37%)
70.96%
(-1.56%)
68.52%
(-1.89%)
🔴 packages/account/src/providers/generated/operations.ts 94.59%
(-0.58%)
100%
(+0%)
83.67%
(-1.74%)
95.03%
(-0.53%)

@Torres-ssf Torres-ssf merged commit d968532 into master Oct 10, 2024
24 checks passed
@Torres-ssf Torres-ssf deleted the mc/feat/add-endpoint-for-checking-user-accounts branch October 10, 2024 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants