Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: un-deprecated network URLs #3532

Merged
merged 9 commits into from
Jan 21, 2025
Merged

chore: un-deprecated network URLs #3532

merged 9 commits into from
Jan 21, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 3, 2025 •
edited
Loading

Summary

  • Undeprecated network URLs
    • DEVNET_NETWORK_URL
    • TESTNET_NETWORK_URL

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Jan 3, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 10:42am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 10:42am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 10:42am

@petertonysmith94 petertonysmith94 changed the title chore: removed network URLs chore!: removed network URLs Jan 3, 2025
@arboleya
Copy link
Member

arboleya commented Jan 3, 2025

It's not a request; I'm just thinking out loud, but I still think there's space for these constants.

@petertonysmith94
Copy link
Contributor Author

It's not a request; I'm just thinking out loud, but I still think there's space for these constants.

For me, I'd favour using environmental variables for network dependant constants, but I can see how these constants could be handy. I'm happy to un-deprecate, if you have a strong opinion.

@petertonysmith94 petertonysmith94 changed the title chore!: removed network URLs chore: undeprecated network URLs Jan 21, 2025
@petertonysmith94 petertonysmith94 changed the title chore: undeprecated network URLs chore: un-deprecated network URLs Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.06%(+0.02%) 70.64%(+0%) 75.1%(+0%) 77.06%(+0.02%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 marked this pull request as ready for review January 21, 2025 11:23
@Torres-ssf Torres-ssf merged commit f986891 into master Jan 21, 2025
24 checks passed
@Torres-ssf Torres-ssf deleted the ps/chore/remove-network-urls branch January 21, 2025 13:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Un-deprecate network URLs
4 participants
@petertonysmith94 @arboleya @danielbate @Torres-ssf