Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove docs validation for ts sdk api docs #43

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Dhaiwat10
Copy link
Member

This PR removes the validation in place for the TS SDK API docs since they have now been isolated in a different project on a different URL (FuelLabs/fuels-ts#3237) and they are now only referenced from the 'main' TS SDK docs.

@Dhaiwat10 Dhaiwat10 self-assigned this Oct 24, 2024
@Dhaiwat10 Dhaiwat10 merged commit 1c646b5 into master Oct 24, 2024
4 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/remove-ts-api-docs branch October 24, 2024 14:08
@@ -94,29 +91,6 @@ function checkForUnusedFiles(srcFolderPath, subfolders) {
const folderPath = path.join(srcFolderPath, folder);
const subfolderNames = fs.readdirSync(folderPath);
const parentFolder = folderPath.split("/").pop();
subfolderNames.forEach((subFile) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhaiwat10 Why was this removed?

petertonysmith94 added a commit that referenced this pull request Oct 28, 2024
petertonysmith94 added a commit that referenced this pull request Oct 28, 2024
# Summary

The @FuelLabs/sdk-ts are looking to migrate our API documentation to an
external host (Vercel). As part of this, we applied the following
changes to the GitHub action to make the possible:

- #43 
- #45 

The above changes have caused our CI to fail. We're exploring a
different route to migrate our API docs, therefore, this PR reverts the
above two PR's.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants