Implement the GM opcode #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
added
the
compiler
2 tasks
sezna
force-pushed
the
sezna/gm_opcode
branch
from
e00c2e0 to
d3e9c85
Compare
sezna
force-pushed
the
sezna/gm_opcode
branch
from
68f44ea to
d3e9c85
Compare
vlopes11
approved these changes
Oct 31, 2021
| @@ -4,8 +4,8 @@ use serde::{Deserialize, Serialize}; | |||
| use std::path::{Path, PathBuf}; | |||
| use std::{io, iter, slice}; | |||
|
|
|||
| pub type Id = [u8; Bytes32::size_of()]; | |||
| pub type Contract = [u8; ContractId::size_of()]; | |||
| pub type Id = [u8; Bytes32::LEN]; | |||
There was a problem hiding this comment.
I don't understand why we don't use the raw types if they can just be represented as &[u8] via https://github.com/FuelLabs/fuel-types/blob/565ac6a25343e487faf10c13c42fb5168f92b087/src/types.rs#L130-L134
There was a problem hiding this comment.
I do not know, was just updating for the api. @leviathanbeak any word on why these types are like this?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the GM opcode to the Sway language, as per the new specs.
Closes #339
This PR also updates
swayto the latestfuel-asmwith the latest op mapping and fixes the corresponding contract addresses.