fix trait implementation imports in star imports #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
added
bug
sezna
requested review from
otrho,
adlerjohn,
canndrew,
emilyaherbert and
eureka-cpu
adlerjohn
reviewed
Jan 6, 2022
eureka-cpu
reviewed
Jan 6, 2022
emilyaherbert
approved these changes
Jan 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the resolution to a bug found by @ControlCplusControlV in Discord. Trait implementations were not being pulled in to the local namespace when a star import was being used to bring the trait in. This doesn't matter with operators, since operators use the fully qualified method path (e.g.
std::core::ops), but if you want to directly call a method, this falls apart.