Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(forc): add manifest formatter #616

Merged
merged 11 commits into from
Jan 14, 2022
Merged

feat(forc): add manifest formatter #616

merged 11 commits into from
Jan 14, 2022

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Jan 11, 2022

This PR fixes issue #422 by implementing a format checker for the forc manifest
file (Forc.toml) in the forc fmt tool.

  • fix: add core dependency in sway example project and fix formatting
  • docs: warn about the formatter needing code that compiles
  • refactor: put the diff display inside its own function
  • feat: format manifest with forc fmt command

@adlerjohn adlerjohn added enhancement New feature or request forc labels Jan 11, 2022
@adlerjohn adlerjohn linked an issue Jan 11, 2022 that may be closed by this pull request
forc: add manifest formatter #422
Closed
@iqdecay iqdecay force-pushed the feat-format-forc-manifest branch from 55fa1b9 to 168fe87 Compare January 11, 2022 16:44
@iqdecay iqdecay marked this pull request as draft January 11, 2022 16:49
adlerjohn
adlerjohn reviewed Jan 11, 2022
View reviewed changes
@iqdecay iqdecay marked this pull request as ready for review January 12, 2022 12:19
@iqdecay iqdecay force-pushed the feat-format-forc-manifest branch from 9a26f92 to 618ade1 Compare January 12, 2022 12:22
@iqdecay iqdecay force-pushed the feat-format-forc-manifest branch from 618ade1 to abb3eec Compare January 12, 2022 14:34
@iqdecay iqdecay force-pushed the feat-format-forc-manifest branch from abb3eec to 0f859d8 Compare January 12, 2022 14:54
@iqdecay @adlerjohn
Update docs/src/getting-started/temporary_workarounds.md
bc569e5 
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
@iqdecay iqdecay requested a review from digorithm January 13, 2022 17:50
adlerjohn
adlerjohn reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve conflicts? The examples were removed in #623, so you don't need those changes anymore.

digorithm
digorithm previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@iqdecay
Copy link
Contributor Author

iqdecay commented Jan 14, 2022

Should be good now!

@iqdecay iqdecay merged commit 9389145 into master Jan 14, 2022
@iqdecay iqdecay deleted the feat-format-forc-manifest branch January 14, 2022 18:28
@adlerjohn adlerjohn mentioned this pull request Jan 21, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@digorithm digorithm digorithm approved these changes

@sezna sezna Awaiting requested review from sezna

Assignees

@iqdecay iqdecay

Labels
enhancement New feature or request forc formatter
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forc: add manifest formatter
4 participants
@iqdecay @adlerjohn @digorithm @sezna