Cache Build Plans in language server #6281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
language server
JoshuaBatty
force-pushed
the
josh/cache_build_plan
branch
from
2e06b31 to
c3ac08e
Compare
Benchmark for f0ef31bClick to view benchmark
|
JoshuaBatty
force-pushed
the
josh/cache_build_plan
branch
from
1647a6e to
e36eca0
Compare
Benchmark for b615a06Click to view benchmark
|
kayagokalp
approved these changes
Jul 22, 2024
IGI-111
approved these changes
Jul 22, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Description closes #5462 related #5445 before we were recreating the build plan on every keystroke. We now cache the result and reuse on subsequent did change events. We invalidate the cache if there has been any modifications to the `Forc.toml` file since the cache was created. Here are the timings when triggering this with a did_change event on the FUSD repo. previous: `80.146ms` with this change: `56µs`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #5462
related #5445
before we were recreating the build plan on every keystroke. We now cache the result and reuse on subsequent did change events. We invalidate the cache if there has been any modifications to the
Forc.tomlfile since the cache was created.Here are the timings when triggering this with a did_change event on the FUSD repo.
previous:
80.146mswith this change:
56µs