Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: bump forc-pkg deps and fix clippy warnings #6311

Merged
merged 5 commits into from
Jul 31, 2024
Merged

chore: bump forc-pkg deps and fix clippy warnings #6311

merged 5 commits into from
Jul 31, 2024

Conversation

JoshuaBatty
Copy link
Member

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested review from a team as code owners July 29, 2024 23:25
@JoshuaBatty JoshuaBatty self-assigned this Jul 29, 2024
@JoshuaBatty JoshuaBatty requested a review from a team July 29, 2024 23:26
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) July 29, 2024 23:39
@github-actions GitHub Actions
Copy link

Benchmark for 9671496

Click to view benchmark
Test Base PR %
code_action 5.1±0.05ms 5.1±0.05ms 0.00%
code_lens 290.6±5.64ns 344.8±12.02ns +18.65%
compile 2.7±0.08s 2.7±0.03s 0.00%
completion 4.5±0.07ms 4.6±0.10ms +2.22%
did_change_with_caching 2.7±0.03s 2.6±0.04s -3.70%
document_symbol 883.1±19.24µs 903.2±38.09µs +2.28%
format 70.0±0.92ms 70.4±1.10ms +0.57%
goto_definition 350.2±8.94µs 336.8±7.72µs -3.83%
highlight 8.8±0.12ms 8.7±0.12ms -1.14%
hover 508.6±5.94µs 495.4±6.32µs -2.60%
idents_at_position 119.3±0.65µs 122.5±0.89µs +2.68%
inlay_hints 631.1±18.80µs 633.3±21.32µs +0.35%
on_enter 474.1±38.34ns 469.3±8.14ns -1.01%
parent_decl_at_position 3.6±0.08ms 3.6±0.03ms 0.00%
prepare_rename 347.9±5.02µs 335.5±8.13µs -3.56%
rename 9.1±0.13ms 8.9±0.06ms -2.20%
semantic_tokens 1178.4±20.18µs 1257.6±12.39µs +6.72%
token_at_position 339.2±2.99µs 328.9±1.85µs -3.04%
tokens_at_position 3.6±0.04ms 3.6±0.03ms 0.00%
tokens_for_file 405.0±1.67µs 406.0±4.32µs +0.25%
traverse 38.1±1.24ms 38.6±0.97ms +1.31%

@JoshuaBatty JoshuaBatty requested a review from mchristopher July 30, 2024 00:10
@github-actions GitHub Actions
Copy link

Benchmark for 3cb4180

Click to view benchmark
Test Base PR %
code_action 5.0±0.20ms 5.0±0.11ms 0.00%
code_lens 286.1±6.82ns 341.8±13.29ns +19.47%
compile 2.7±0.07s 2.6±0.05s -3.70%
completion 4.5±0.06ms 4.5±0.07ms 0.00%
did_change_with_caching 2.7±0.04s 2.5±0.05s -7.41%
document_symbol 928.6±25.35µs 851.7±18.37µs -8.28%
format 69.7±0.96ms 70.0±0.97ms +0.43%
goto_definition 341.5±4.03µs 344.2±3.76µs +0.79%
highlight 8.6±0.02ms 8.7±0.35ms +1.16%
hover 496.2±3.46µs 500.2±7.91µs +0.81%
idents_at_position 118.4±0.31µs 119.2±0.27µs +0.68%
inlay_hints 627.7±34.53µs 655.9±82.24µs +4.49%
on_enter 477.7±14.59ns 482.4±8.00ns +0.98%
parent_decl_at_position 3.5±0.03ms 3.6±0.03ms +2.86%
prepare_rename 337.6±5.08µs 345.5±7.92µs +2.34%
rename 8.9±0.06ms 8.9±0.13ms 0.00%
semantic_tokens 1243.5±10.07µs 1260.2±14.05µs +1.34%
token_at_position 329.5±2.71µs 338.3±1.82µs +2.67%
tokens_at_position 3.6±0.04ms 3.6±0.15ms 0.00%
tokens_for_file 396.4±2.37µs 404.1±2.06µs +1.94%
traverse 38.7±0.96ms 37.7±1.24ms -2.58%

@JoshuaBatty JoshuaBatty requested a review from a team July 30, 2024 02:03
@github-actions GitHub Actions
Copy link

Benchmark for 8dd5496

Click to view benchmark
Test Base PR %
code_action 5.0±0.08ms 5.0±0.01ms 0.00%
code_lens 287.6±7.78ns 343.9±14.56ns +19.58%
compile 2.6±0.07s 2.6±0.05s 0.00%
completion 4.5±0.12ms 4.5±0.06ms 0.00%
did_change_with_caching 2.6±0.04s 2.5±0.04s -3.85%
document_symbol 837.7±31.74µs 889.3±36.20µs +6.16%
format 69.3±1.94ms 70.2±0.93ms +1.30%
goto_definition 338.9±6.21µs 344.2±7.20µs +1.56%
highlight 8.6±0.04ms 8.6±0.13ms 0.00%
hover 493.9±6.79µs 493.5±5.96µs -0.08%
idents_at_position 118.6±0.30µs 122.3±0.56µs +3.12%
inlay_hints 624.5±27.22µs 628.3±8.05µs +0.61%
on_enter 470.4±14.37ns 473.7±12.96ns +0.70%
parent_decl_at_position 3.6±0.03ms 3.5±0.03ms -2.78%
prepare_rename 341.5±22.29µs 344.0±6.92µs +0.73%
rename 9.0±0.45ms 8.9±0.01ms -1.11%
semantic_tokens 1220.1±14.83µs 1260.8±12.16µs +3.34%
token_at_position 339.1±3.07µs 331.1±2.19µs -2.36%
tokens_at_position 3.6±0.03ms 3.5±0.07ms -2.78%
tokens_for_file 401.7±1.84µs 395.2±1.84µs -1.62%
traverse 36.9±0.77ms 36.9±0.81ms 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for d1e7a07

Click to view benchmark
Test Base PR %
code_action 5.0±0.10ms 5.1±0.03ms +2.00%
code_lens 287.5±11.22ns 346.5±27.64ns +20.52%
compile 2.6±0.04s 2.6±0.04s 0.00%
completion 4.5±0.09ms 4.6±0.07ms +2.22%
did_change_with_caching 2.6±0.04s 2.6±0.05s 0.00%
document_symbol 905.3±46.72µs 859.1±21.37µs -5.10%
format 69.7±0.90ms 70.5±0.58ms +1.15%
goto_definition 348.5±7.67µs 363.5±6.13µs +4.30%
highlight 8.6±0.01ms 8.7±0.15ms +1.16%
hover 502.2±6.84µs 532.9±11.69µs +6.11%
idents_at_position 119.5±0.55µs 120.5±1.08µs +0.84%
inlay_hints 627.6±22.92µs 660.8±33.36µs +5.29%
on_enter 469.4±22.41ns 475.6±8.09ns +1.32%
parent_decl_at_position 3.6±0.03ms 3.6±0.03ms 0.00%
prepare_rename 345.9±14.47µs 376.3±9.84µs +8.79%
rename 8.9±0.17ms 9.0±0.29ms +1.12%
semantic_tokens 1266.3±15.38µs 1276.2±14.44µs +0.78%
token_at_position 334.7±2.19µs 359.7±1.88µs +7.47%
tokens_at_position 3.6±0.03ms 3.6±0.03ms 0.00%
tokens_for_file 400.8±5.71µs 403.6±3.48µs +0.70%
traverse 38.0±0.75ms 38.8±0.66ms +2.11%

@JoshuaBatty JoshuaBatty merged commit 893e59f into master Jul 31, 2024
39 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/update_gix branch July 31, 2024 10:19
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
@JoshuaBatty @esdrubal
chore: bump forc-pkg deps and fix clippy warnings (#6311)
a525004 
## Description


## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@IGI-111 IGI-111 IGI-111 approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

@mchristopher mchristopher Awaiting requested review from mchristopher

Assignees

@JoshuaBatty JoshuaBatty

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaBatty @IGI-111 @kayagokalp