Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-pin LSP tests to published version of std and re-enable commented out tests #6315

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Jul 30, 2024

Description

closes #4211
closes #6258

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner July 30, 2024 01:22
@JoshuaBatty JoshuaBatty requested a review from a team July 30, 2024 01:23
@JoshuaBatty JoshuaBatty self-assigned this Jul 30, 2024
@JoshuaBatty JoshuaBatty added language server LSP server testing General testing labels Jul 30, 2024
@JoshuaBatty JoshuaBatty changed the title Re-pin LSP tests to publish version of std and re-enable commented out tests Re-pin LSP tests to published version of std and re-enable commented out tests Jul 30, 2024
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) July 30, 2024 01:27
Copy link

Benchmark for cbe994a

Click to view benchmark
Test Base PR %
code_action 5.1±0.11ms 5.1±0.12ms 0.00%
code_lens 288.0±7.75ns 286.7±9.84ns -0.45%
compile 2.7±0.04s 2.6±0.04s -3.70%
completion 4.5±0.12ms 4.6±0.11ms +2.22%
did_change_with_caching 2.6±0.03s 2.6±0.04s 0.00%
document_symbol 910.0±27.65µs 883.9±43.38µs -2.87%
format 72.4±1.54ms 69.4±1.20ms -4.14%
goto_definition 339.8±5.06µs 346.7±3.56µs +2.03%
highlight 8.7±0.25ms 8.7±0.21ms 0.00%
hover 500.7±7.51µs 504.3±17.70µs +0.72%
idents_at_position 119.9±0.39µs 119.0±1.65µs -0.75%
inlay_hints 631.7±28.12µs 703.6±14.67µs +11.38%
on_enter 468.6±9.26ns 484.0±20.92ns +3.29%
parent_decl_at_position 3.6±0.04ms 3.6±0.03ms 0.00%
prepare_rename 337.2±6.94µs 343.3±6.06µs +1.81%
rename 9.2±0.27ms 9.0±0.22ms -2.17%
semantic_tokens 1240.3±15.18µs 1274.9±21.40µs +2.79%
token_at_position 333.2±3.27µs 343.1±2.68µs +2.97%
tokens_at_position 3.6±0.02ms 3.6±0.07ms 0.00%
tokens_for_file 400.8±2.39µs 408.4±5.02µs +1.90%
traverse 38.0±0.96ms 38.3±0.90ms +0.79%

Copy link

Benchmark for bac3fcf

Click to view benchmark
Test Base PR %
code_action 5.0±0.02ms 5.0±0.08ms 0.00%
code_lens 287.6±10.32ns 287.3±11.60ns -0.10%
compile 2.7±0.05s 2.7±0.05s 0.00%
completion 4.6±0.08ms 4.5±0.14ms -2.17%
did_change_with_caching 2.7±0.02s 2.6±0.03s -3.70%
document_symbol 858.7±26.01µs 847.7±18.59µs -1.28%
format 70.4±0.84ms 70.8±1.25ms +0.57%
goto_definition 342.5±5.36µs 344.4±5.96µs +0.55%
highlight 8.7±0.06ms 8.7±0.15ms 0.00%
hover 502.6±5.24µs 501.4±5.95µs -0.24%
idents_at_position 119.4±1.04µs 120.2±1.51µs +0.67%
inlay_hints 629.8±13.93µs 629.1±25.70µs -0.11%
on_enter 471.0±7.82ns 476.4±13.10ns +1.15%
parent_decl_at_position 3.6±0.03ms 3.5±0.01ms -2.78%
prepare_rename 341.5±4.51µs 344.3±6.21µs +0.82%
rename 9.0±0.05ms 8.9±0.09ms -1.11%
semantic_tokens 1261.4±12.77µs 1318.0±51.27µs +4.49%
token_at_position 333.3±1.89µs 333.5±2.58µs +0.06%
tokens_at_position 3.6±0.04ms 3.5±0.04ms -2.78%
tokens_for_file 398.3±4.66µs 401.7±2.48µs +0.85%
traverse 38.2±1.50ms 37.9±0.85ms -0.79%

@IGI-111 IGI-111 requested a review from a team July 30, 2024 02:42
Copy link

Benchmark for d28eb5d

Click to view benchmark
Test Base PR %
code_action 5.0±0.02ms 5.0±0.10ms 0.00%
code_lens 289.0±9.66ns 284.3±4.17ns -1.63%
compile 2.6±0.07s 2.6±0.03s 0.00%
completion 4.5±0.02ms 4.5±0.09ms 0.00%
did_change_with_caching 2.6±0.04s 2.6±0.03s 0.00%
document_symbol 919.9±21.76µs 906.9±43.40µs -1.41%
format 70.4±1.00ms 69.8±0.82ms -0.85%
goto_definition 348.9±6.25µs 345.5±10.49µs -0.97%
highlight 8.6±0.01ms 8.7±0.12ms +1.16%
hover 507.1±5.95µs 500.8±5.04µs -1.24%
idents_at_position 118.3±0.19µs 119.2±0.36µs +0.76%
inlay_hints 626.5±22.72µs 629.6±23.88µs +0.49%
on_enter 472.5±13.91ns 470.5±14.13ns -0.42%
parent_decl_at_position 3.6±0.03ms 3.6±0.06ms 0.00%
prepare_rename 347.5±5.84µs 344.4±8.91µs -0.89%
rename 8.9±0.11ms 9.0±0.13ms +1.12%
semantic_tokens 1306.5±8.15µs 1250.5±14.24µs -4.29%
token_at_position 344.7±2.22µs 335.7±5.57µs -2.61%
tokens_at_position 3.5±0.03ms 3.6±0.02ms +2.86%
tokens_for_file 405.7±6.70µs 400.0±6.73µs -1.40%
traverse 37.6±0.57ms 37.6±0.83ms 0.00%

@JoshuaBatty JoshuaBatty merged commit a727d1f into master Jul 31, 2024
39 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/repin_lsp_tests branch July 31, 2024 02:09
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
…d out tests (#6315)

## Description
closes #4211
closes #6258

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
language server LSP server testing General testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable LSP tests and pin std to latest release test(lsp): inconsistent go_to_definition_for_paths test
4 participants