Fixes unreachable macro crashing compiler. #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
bug
Benchmark for c565dffClick to view benchmark
|
In case of a bad input given to the lexer it is possible to generate an AST with invalid ImplItem tuples. This fix replaces the unreachable macro with an CompileError::Internal. This allows the user to see the lexer errors and fix them which will also take care of the new errors. Fixes #6339.
Benchmark for 55537fcClick to view benchmark
|
tritao
changed the title
IGI-111
approved these changes
Aug 7, 2024
Benchmark for 54b8fe3Click to view benchmark
|
Benchmark for 976ebaaClick to view benchmark
|
tritao
approved these changes
Aug 7, 2024
Benchmark for 204da92Click to view benchmark
|
Benchmark for 1d2e0f2Click to view benchmark
|
esdrubal
added a commit
that referenced
this pull request
Aug 13, 2024
## Description In case of a bad input given to the lexer, it is possible to generate an AST with invalid ImplItem tuples. This fix replaces the unreachable macro with an CompileError::Internal. This allows the user to see the lexer errors and fix them which will also address the new errors. Fixes #6339. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: IGI-111 <igi-111@protonmail.com> Co-authored-by: João Matos <joao@tritao.eu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of a bad input given to the lexer, it is possible to generate an AST with invalid ImplItem tuples.
This fix replaces the unreachable macro with an CompileError::Internal. This allows the user to see the lexer errors and fix them which will also address the new errors.
Fixes #6339.
Checklist
Breaking*orNew Featurelabels where relevant.