Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Update docs for forc-client #6403

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 7, 2024

Description

Apply @bitzoic 's comments from #6069

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel requested review from kayagokalp and bitzoic August 7, 2024 15:14
@sdankel sdankel marked this pull request as ready for review August 7, 2024 15:15
@sdankel sdankel requested review from a team as code owners August 7, 2024 15:15
@sdankel sdankel enabled auto-merge (squash) August 7, 2024 15:18
@K1-R1 K1-R1 requested a review from a team August 7, 2024 15:25
Copy link
Contributor

@laishawadhwa laishawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@sdankel sdankel merged commit 93656fe into master Aug 7, 2024
42 checks passed
@sdankel sdankel deleted the sophie/forc-client-docs branch August 7, 2024 15:49
esdrubal pushed a commit that referenced this pull request Aug 13, 2024
## Description

Apply @bitzoic 's comments from
#6069

## Checklist

- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants