Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: bump to 0.63.0 #6421

Merged
merged 8 commits into from
Aug 19, 2024
Merged

chore: bump to 0.63.0 #6421

merged 8 commits into from
Aug 19, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 15, 2024 •
edited
Loading

Description

To be merged after #6250

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review August 15, 2024 22:06
@sdankel sdankel requested review from a team as code owners August 15, 2024 22:06
@sdankel sdankel marked this pull request as draft August 15, 2024 22:18
@github-actions GitHub Actions
Copy link

Benchmark for 2736dc9

Click to view benchmark
Test Base PR %
code_action 5.0±0.05ms 5.2±0.01ms +4.00%
code_lens 280.5±3.35ns 285.4±5.04ns +1.75%
compile 2.6±0.05s 2.6±0.05s 0.00%
completion 4.5±0.05ms 4.7±0.09ms +4.44%
did_change_with_caching 2.5±0.03s 2.5±0.03s 0.00%
document_symbol 902.3±23.10µs 941.8±49.91µs +4.38%
format 67.0±0.58ms 85.9±1.30ms +28.21%
goto_definition 338.8±3.55µs 343.8±12.28µs +1.48%
highlight 8.6±0.04ms 9.0±0.02ms +4.65%
hover 489.8±3.98µs 498.2±6.86µs +1.71%
idents_at_position 118.8±0.50µs 121.0±0.55µs +1.85%
inlay_hints 629.8±17.58µs 688.6±25.67µs +9.34%
on_enter 2.1±0.05µs 1884.0±38.30ns -10.29%
parent_decl_at_position 3.5±0.03ms 3.7±0.03ms +5.71%
prepare_rename 337.3±4.10µs 338.8±5.07µs +0.44%
rename 9.0±0.37ms 9.3±0.02ms +3.33%
semantic_tokens 1195.0±7.07µs 1229.1±74.48µs +2.85%
token_at_position 336.6±1.88µs 328.5±2.27µs -2.41%
tokens_at_position 3.5±0.03ms 3.7±0.01ms +5.71%
tokens_for_file 394.0±2.15µs 403.5±6.02µs +2.41%
traverse 33.7±0.89ms 33.8±0.77ms +0.30%

@DefiCake DefiCake mentioned this pull request Aug 16, 2024
Closed
@github-actions GitHub Actions
Copy link

Benchmark for 101d0d3

Click to view benchmark
Test Base PR %
code_action 5.2±0.01ms 5.2±0.07ms 0.00%
code_lens 303.6±18.06ns 346.7±9.80ns +14.20%
compile 2.7±0.07s 2.7±0.05s 0.00%
completion 4.7±0.03ms 4.6±0.07ms -2.13%
did_change_with_caching 2.6±0.06s 2.5±0.06s -3.85%
document_symbol 880.2±10.22µs 918.0±19.06µs +4.29%
format 71.4±0.64ms 83.3±0.99ms +16.67%
goto_definition 336.7±6.30µs 347.9±11.86µs +3.33%
highlight 9.1±0.07ms 8.9±0.01ms -2.20%
hover 484.0±5.25µs 498.1±20.14µs +2.91%
idents_at_position 118.7±0.52µs 120.1±0.77µs +1.18%
inlay_hints 633.8±20.55µs 633.2±23.74µs -0.09%
on_enter 2.1±0.04µs 1991.5±76.64ns -5.17%
parent_decl_at_position 3.7±0.03ms 3.7±0.05ms 0.00%
prepare_rename 332.0±4.60µs 341.6±8.08µs +2.89%
rename 9.4±0.08ms 9.3±0.21ms -1.06%
semantic_tokens 1189.8±14.62µs 1221.6±7.09µs +2.67%
token_at_position 328.2±3.96µs 334.1±12.54µs +1.80%
tokens_at_position 3.8±0.05ms 3.7±0.04ms -2.63%
tokens_for_file 395.8±2.99µs 396.4±3.88µs +0.15%
traverse 33.1±0.81ms 34.5±0.65ms +4.23%

@github-actions GitHub Actions
Copy link

Benchmark for aa27074

Click to view benchmark
Test Base PR %
code_action 5.1±0.13ms 5.0±0.12ms -1.96%
code_lens 291.0±8.50ns 327.6±10.14ns +12.58%
compile 2.5±0.06s 2.5±0.05s 0.00%
completion 4.5±0.10ms 4.5±0.16ms 0.00%
did_change_with_caching 2.4±0.05s 2.4±0.03s 0.00%
document_symbol 874.8±48.28µs 874.6±23.44µs -0.02%
format 68.4±1.93ms 79.3±1.67ms +15.94%
goto_definition 321.5±6.58µs 323.2±10.35µs +0.53%
highlight 8.7±0.20ms 8.6±0.23ms -1.15%
hover 469.1±9.48µs 468.7±12.74µs -0.09%
idents_at_position 114.8±2.66µs 114.5±2.64µs -0.26%
inlay_hints 605.1±15.87µs 603.0±17.33µs -0.35%
on_enter 1944.7±73.37ns 1926.4±50.47ns -0.94%
parent_decl_at_position 3.5±0.06ms 3.5±0.07ms 0.00%
prepare_rename 318.7±7.19µs 325.1±9.15µs +2.01%
rename 9.0±0.20ms 8.9±0.21ms -1.11%
semantic_tokens 1185.1±24.50µs 1187.0±32.76µs +0.16%
token_at_position 319.6±6.43µs 321.0±7.75µs +0.44%
tokens_at_position 3.5±0.06ms 3.5±0.08ms 0.00%
tokens_for_file 383.0±7.65µs 376.2±5.22µs -1.78%
traverse 31.9±0.87ms 32.6±1.00ms +2.19%

@kayagokalp kayagokalp marked this pull request as ready for review August 17, 2024 11:47
@kayagokalp
Copy link
Member

Should we merge it right away, or monday?

kayagokalp
kayagokalp requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized we need to wait for #6429

@JoshuaBatty
Copy link
Member

would be nice for #6424 to land in this release.

kayagokalp
kayagokalp previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should block until #6424 is in, otherwise we are without docs for the release 🙃 Approving to remove my RC

IGI-111
IGI-111 previously approved these changes Aug 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Benchmark for 78247bc

Click to view benchmark
Test Base PR %
code_action 5.3±0.08ms 5.4±0.13ms +1.89%
code_lens 289.1±7.29ns 283.2±8.12ns -2.04%
compile 2.8±0.07s 2.8±0.06s 0.00%
completion 4.9±0.14ms 4.8±0.25ms -2.04%
did_change_with_caching 2.7±0.05s 2.7±0.05s 0.00%
document_symbol 930.9±15.44µs 859.2±25.20µs -7.70%
format 68.4±0.54ms 86.2±1.06ms +26.02%
goto_definition 338.4±3.70µs 341.3±6.18µs +0.86%
highlight 9.2±0.15ms 9.1±0.14ms -1.09%
hover 495.4±6.58µs 498.3±6.73µs +0.59%
idents_at_position 118.0±0.40µs 118.1±1.30µs +0.08%
inlay_hints 635.5±7.58µs 641.1±30.27µs +0.88%
on_enter 2.0±0.03µs 2.0±0.06µs 0.00%
parent_decl_at_position 3.8±0.03ms 3.8±0.08ms 0.00%
prepare_rename 336.4±8.02µs 339.5±5.85µs +0.92%
rename 9.6±0.25ms 9.6±0.18ms 0.00%
semantic_tokens 1171.7±18.86µs 1223.2±7.94µs +4.40%
token_at_position 337.0±1.26µs 334.2±3.07µs -0.83%
tokens_at_position 3.7±0.03ms 3.7±0.04ms 0.00%
tokens_for_file 404.1±2.49µs 404.1±3.27µs 0.00%
traverse 34.9±0.64ms 35.7±0.66ms +2.29%

@IGI-111 IGI-111 dismissed stale reviews from kayagokalp and themself via 95ff22e August 19, 2024 15:22
@github-actions GitHub Actions
Copy link

Benchmark for 2bd46fb

Click to view benchmark
Test Base PR %
code_action 5.5±0.12ms 5.5±0.14ms 0.00%
code_lens 302.0±12.92ns 296.0±8.35ns -1.99%
compile 2.8±0.05s 2.9±0.04s +3.57%
completion 5.1±0.16ms 4.9±0.13ms -3.92%
did_change_with_caching 2.8±0.07s 2.7±0.03s -3.57%
document_symbol 930.9±17.51µs 935.9±18.99µs +0.54%
format 68.7±0.70ms 86.0±0.93ms +25.18%
goto_definition 338.7±7.18µs 343.9±6.92µs +1.54%
highlight 9.3±0.27ms 9.3±0.15ms 0.00%
hover 493.8±7.20µs 491.1±4.99µs -0.55%
idents_at_position 117.6±0.41µs 119.7±0.47µs +1.79%
inlay_hints 637.7±18.56µs 632.6±23.28µs -0.80%
on_enter 2.0±0.06µs 2.0±0.05µs 0.00%
parent_decl_at_position 3.8±0.08ms 3.8±0.09ms 0.00%
prepare_rename 334.8±4.39µs 341.5±8.72µs +2.00%
rename 9.9±0.23ms 9.8±0.15ms -1.01%
semantic_tokens 1201.8±14.83µs 1296.3±17.50µs +7.86%
token_at_position 334.4±3.02µs 342.3±2.44µs +2.36%
tokens_at_position 3.9±0.09ms 3.8±0.08ms -2.56%
tokens_for_file 397.6±2.91µs 401.7±3.62µs +1.03%
traverse 36.2±0.86ms 36.4±1.09ms +0.55%

@github-actions GitHub Actions
Copy link

Benchmark for 8046d3c

Click to view benchmark
Test Base PR %
code_action 5.3±0.06ms 5.2±0.10ms -1.89%
code_lens 298.6±7.80ns 282.6±8.02ns -5.36%
compile 2.7±0.04s 2.7±0.05s 0.00%
completion 4.7±0.04ms 4.7±0.01ms 0.00%
did_change_with_caching 2.5±0.06s 2.5±0.05s 0.00%
document_symbol 900.9±26.25µs 993.7±47.39µs +10.30%
format 66.8±0.51ms 87.2±0.61ms +30.54%
goto_definition 341.5±6.38µs 334.2±4.03µs -2.14%
highlight 9.1±0.03ms 9.0±0.07ms -1.10%
hover 491.0±6.51µs 484.7±4.62µs -1.28%
idents_at_position 119.0±0.27µs 119.2±1.14µs +0.17%
inlay_hints 648.8±24.14µs 685.0±27.07µs +5.58%
on_enter 2.0±0.07µs 1898.8±49.39ns -5.06%
parent_decl_at_position 3.7±0.04ms 3.7±0.03ms 0.00%
prepare_rename 340.4±9.16µs 339.3±8.71µs -0.32%
rename 9.4±0.13ms 9.3±0.11ms -1.06%
semantic_tokens 1251.9±9.49µs 1239.7±10.69µs -0.97%
token_at_position 333.5±4.06µs 337.4±1.76µs +1.17%
tokens_at_position 3.7±0.03ms 3.7±0.02ms 0.00%
tokens_for_file 395.2±2.66µs 402.2±3.72µs +1.77%
traverse 33.4±1.23ms 33.9±0.73ms +1.50%

@sdankel sdankel requested review from IGI-111, kayagokalp, JoshuaBatty and a team August 19, 2024 16:30
@IGI-111 IGI-111 merged commit da9b323 into master Aug 19, 2024
39 checks passed
@IGI-111 IGI-111 deleted the sophie/bump-0.63.0 branch August 19, 2024 16:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

@IGI-111 IGI-111 Awaiting requested review from IGI-111

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdankel @kayagokalp @JoshuaBatty @Voxelot @IGI-111