Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix some incorrectly parsed tokens. #643

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix some incorrectly parsed tokens. #643

merged 2 commits into from
Jan 14, 2022

Conversation

emilyaherbert
Copy link
Contributor

Closes #642

@emilyaherbert emilyaherbert added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Jan 14, 2022
@emilyaherbert emilyaherbert requested review from otrho and sezna January 14, 2022 21:23
@emilyaherbert emilyaherbert self-assigned this Jan 14, 2022
@sezna
Copy link
Contributor

sezna commented Jan 14, 2022

I believe the original intention behind function names being variable expressions was that they'd be treated as passable variables, kind of like in Rust. We didn't end up doing that though so I guess it doesn't matter too much. Note for parser 2.0 :)

sezna
sezna reviewed Jan 14, 2022
View reviewed changes
@emilyaherbert emilyaherbert requested a review from sezna January 14, 2022 22:22
@emilyaherbert emilyaherbert merged commit 0ee1590 into master Jan 14, 2022
@emilyaherbert emilyaherbert deleted the emilyaherbert-642/some-tokens-parsed-incorrectly branch January 14, 2022 23:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sezna sezna sezna approved these changes

@otrho otrho Awaiting requested review from otrho

Assignees

@emilyaherbert emilyaherbert

Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate: some tokens are accidentally getting parsed under the wrong rule.
2 participants
@emilyaherbert @sezna