Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes impl self duplicated missing error. #6493

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Sep 3, 2024

Description

While inserting trait implementations into the trait map we now compare the implementing type_id without matching UnkownGenerics trait constraints. Matching the trait constraints was causing a missing error.

Fixes #6381

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

While inserting trait implementations into the trait map we now compare
the implementing type_id without matching UnkownGenerics trait
constraints. Matching the trait constraints was causing a missing error.

Fixes #6381
@esdrubal esdrubal added bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Sep 3, 2024
@esdrubal esdrubal self-assigned this Sep 3, 2024
Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #6493 will not alter performance

Comparing esdrubal/fix_impl_self_duplicated (4e693d3) with master (8cb7796)

Summary

✅ 21 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review September 3, 2024 15:58
@esdrubal esdrubal requested a review from a team as a code owner September 3, 2024 15:58
@esdrubal esdrubal merged commit 253330d into master Sep 3, 2024
40 checks passed
@esdrubal esdrubal deleted the esdrubal/fix_impl_self_duplicated branch September 3, 2024 23:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trait Functions With the Same Name Get Disambiguated Arbitrarily
4 participants