Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use cargo-nextest with retries for flaky LSP test #6521

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Sep 10, 2024

Description

This PR introduces cargo-nextest to improve our test runs. We've configured 2 retries for the go_to_definition_for_paths test, which has been intermittently failing. The LSP CI workflow has been updated to use cargo-nextest.

Should mitigate #6029 until we get to the root cause why these tests are flaky.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested review from a team as code owners September 10, 2024 02:47
@JoshuaBatty JoshuaBatty self-assigned this Sep 10, 2024
Copy link

codspeed-hq bot commented Sep 10, 2024

CodSpeed Performance Report

Merging #6521 will degrade performances by 17.77%

Comparing josh/cargo-nextest (3b0eaf4) with master (7d574a9)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master josh/cargo-nextest Change
document_symbol 4.3 ms 5.3 ms -17.77%

alfiedotwtf
alfiedotwtf previously approved these changes Sep 10, 2024
@JoshuaBatty JoshuaBatty requested a review from a team September 10, 2024 03:38
sdankel
sdankel previously approved these changes Sep 10, 2024
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If this works out, we could try it for #6509 as well.

@JoshuaBatty JoshuaBatty dismissed stale reviews from sdankel and alfiedotwtf via 3f92272 September 10, 2024 23:27
@JoshuaBatty JoshuaBatty merged commit 2f4fa65 into master Sep 11, 2024
40 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/cargo-nextest branch September 11, 2024 04:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants