Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add a build script to forc-client to keep proxy abi in sync with file #6535

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

kayagokalp
Copy link
Member

Description

closes #6527

@kayagokalp kayagokalp self-assigned this Sep 12, 2024
@kayagokalp kayagokalp requested review from a team as code owners September 12, 2024 00:00
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to come up with a nicer solution for #6527 at some point but this is fine for now

@JoshuaBatty JoshuaBatty requested a review from a team September 12, 2024 00:52
@kayagokalp kayagokalp enabled auto-merge (squash) September 12, 2024 01:18
@kayagokalp kayagokalp merged commit ba153b2 into master Sep 15, 2024
35 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/6527 branch September 15, 2024 19:42
kayagokalp added a commit that referenced this pull request Sep 19, 2024
…ment tests (#6561)

## Description
closes #6558.

This PR fixes an issue with the forc-client build script that causes the
deployment tests to be updated manually for each proxy abi change. This
is a follow up on #6535 and was overlooked in that one. Not critical as
it does not break anything on the user side but rather an code-quality
issue.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a build.rs script for forc-client to auto update proxy abi from file to source code
4 participants