Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor type resolve to deal with ResolvedDeclaration. #6659

Closed
wants to merge 1 commit into from

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Oct 20, 2024

Description

Refactor type resolving to deal with ResolvedDeclaration instead of just ty::TyDecl.

Allows further re-use of this code to deal with parsed declarations too.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Oct 20, 2024
@tritao tritao self-assigned this Oct 20, 2024
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6659 will degrade performances by 16.87%

Comparing tritao:type-resolve-resolved (ab48ec9) with master (029c593)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master tritao:type-resolve-resolved Change
document_symbol 4.4 ms 5.3 ms -16.87%

@tritao tritao marked this pull request as ready for review October 20, 2024 17:30
@tritao tritao requested a review from a team as a code owner October 20, 2024 17:30
@tritao
Copy link
Contributor Author

tritao commented Oct 23, 2024

Closing in favour of #6660.

@tritao tritao closed this Oct 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant