Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Profiling support #6705

Merged
merged 13 commits into from
Nov 15, 2024
Merged

Profiling support #6705

merged 13 commits into from
Nov 15, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Nov 8, 2024

Description

This pull request adds the profile feature in the Sway compiler.

It communicates with an external forc-perf executable in order to signal the beginning and end of different compilation phases for profiling purposes.

(re-opening of #6565)

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler General compiler. Should eventually become more specific as the issue is triaged label Nov 8, 2024
@tritao tritao self-assigned this Nov 8, 2024
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #6705 will not alter performance

Comparing tritao:profiler (74bb491) with master (9951c1d)

Summary

✅ 22 untouched benchmarks

@tritao tritao marked this pull request as ready for review November 8, 2024 14:27
@tritao tritao requested review from a team as code owners November 8, 2024 14:27
@tritao
Copy link
Contributor Author

tritao commented Nov 14, 2024

@FuelLabs/tooling @FuelLabs/leads can I get an approval?

@tritao tritao merged commit 6e31144 into FuelLabs:master Nov 15, 2024
41 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants