-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rename forc doc --manifest-path
to --path
#6797
Conversation
Thanks for the contribution! Before we can merge this, we need @amiremohamadi to sign the Fuel Labs Contributor License Agreement. |
There are still references to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 😄 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitzoic We use to mark the breaking changes in the forc
CLI with the breaking_change
label and also to explain the change in the PR for devs who will eventually need to migrate their, e.g. CI scripts.
I would expect the same here. If devs, e.g., generate docs as a CI step this could break their workflows.
UPDATE: @amiremohamadi found a good solution for avoiding breaking change altogether, by adding the old manifest-path
as an alias for the new path
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Closes #5789
Checklist
Breaking*
orNew Feature
labels where relevant.