Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add splice method to Bytes #6823

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Add splice method to Bytes #6823

merged 13 commits into from
Jan 23, 2025

Conversation

SwayStar123
Copy link
Collaborator

@SwayStar123 SwayStar123 commented Jan 9, 2025

Description

Adds a splice method to bytes that lets you select start and end indices, and returns the range of bytes, removing them from the original bytes.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Jan 9, 2025
@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Jan 9, 2025
@SwayStar123 SwayStar123 marked this pull request as ready for review January 9, 2025 11:52
@SwayStar123 SwayStar123 requested review from a team as code owners January 9, 2025 11:52
@K1-R1
Copy link
Member

K1-R1 commented Jan 9, 2025

I like the addition of splice, but I think we should match Rust's Vec impl https://doc.rust-lang.org/std/vec/struct.Vec.html#method.splice by taking a second optional param replace_with

jjcnn
jjcnn previously approved these changes Jan 17, 2025
K1-R1
K1-R1 previously approved these changes Jan 21, 2025
@SwayStar123 SwayStar123 dismissed stale reviews from K1-R1 and jjcnn via 583deff January 21, 2025 15:47
@SwayStar123 SwayStar123 merged commit 986aee2 into master Jan 23, 2025
37 of 39 checks passed
@SwayStar123 SwayStar123 deleted the swaystar123/bytes-splicing branch January 23, 2025 10:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants