Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add resize() to Vec and Bytes #6864

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Add resize() to Vec and Bytes #6864

merged 5 commits into from
Jan 29, 2025

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Jan 28, 2025

Description

There exists no resize() functionality for Vec and Bytes. This has been implemented in this PR and mimics Rust's behavior.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added the lib: std Standard library label Jan 28, 2025
@bitzoic bitzoic self-assigned this Jan 28, 2025
@bitzoic bitzoic requested review from a team as code owners January 28, 2025 13:17
Copy link
Member

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few nits

@K1-R1 K1-R1 requested a review from a team January 28, 2025 13:52
@bitzoic bitzoic requested a review from K1-R1 January 28, 2025 14:09
@IGI-111 IGI-111 merged commit 1194375 into master Jan 29, 2025
39 checks passed
@IGI-111 IGI-111 deleted the bitzoic-vec-resize branch January 29, 2025 09:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants