Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix unhelpful error found when there is an unimplemented feature. #700

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Fix unhelpful error found when there is an unimplemented feature. #700

merged 2 commits into from
Jan 25, 2022

Conversation

emilyaherbert
Copy link
Contributor

Closes #415. Removes the onslaught of expected: unknown due to error messages when you have an unimplemented feature.

@emilyaherbert emilyaherbert added the compiler General compiler. Should eventually become more specific as the issue is triaged label Jan 25, 2022
@emilyaherbert emilyaherbert self-assigned this Jan 25, 2022
nfurfaro
nfurfaro approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emilyaherbert emilyaherbert merged commit 258e926 into master Jan 25, 2022
@emilyaherbert emilyaherbert deleted the emilyaherbert-415/remove-unhelpful-error-message branch January 25, 2022 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nfurfaro nfurfaro nfurfaro approved these changes

@otrho otrho Awaiting requested review from otrho

@canndrew canndrew Awaiting requested review from canndrew

@sezna sezna Awaiting requested review from sezna

Assignees

@emilyaherbert emilyaherbert

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful error found for unimplemented feature
2 participants
@emilyaherbert @nfurfaro