bugfix: Classes that contain :is
or :where
in their names are no longer unintentionally purged
#1187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Class selectors that contained
:is
or:where
within their names were being unintentionally purged. The use-case that brought about this issue was using these pseudo-classes in tailwind (e.g.class="[&:where(.some-class)]:text-black"
), which would generate the following CSS:This regex will misfire for the class above and for any classes that contain
:where
or:is
in their names (even when the class name is added to the safelist!):As such, I added the appropriate tests, slightly widened the regex and added a more rigorous check for if the functional pseudo-class is empty of selectors:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...