Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Windows config path fix #229

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Windows config path fix #229

merged 2 commits into from
Oct 26, 2019

Conversation

AlexanderOpran
Copy link
Contributor

Proposed changes

Currently using path.resolve on windows results in invalid paths. Replaced path.resolve with path.join.

#137

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ffloriel
Copy link
Member

Thanks!

@Ffloriel Ffloriel merged commit 3c850de into FullHuman:master Oct 26, 2019
@Misiu
Copy link

Misiu commented Oct 29, 2019

@Ffloriel when can we expect a new release? Maybe 1.4.1? I'm using Windows but I'd like to avoid editing any of the dependencies.

@Ffloriel
Copy link
Member

Ffloriel commented Oct 29, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants