Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hotfix/selector regexp fix #241

Merged
merged 2 commits into from
Dec 8, 2019

Conversation

samzlab
Copy link

@samzlab samzlab commented Nov 22, 2019

Proposed changes

Replace simple regex test on "Tag" type selectors and using parent lookup for :nth-* pseudo selectors

Bumped semver to 1.4.2 (from 1.4.1)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Ffloriel Ffloriel self-requested a review December 2, 2019 20:28
@Ffloriel
Copy link
Member

Ffloriel commented Dec 2, 2019

Thanks a lot! Will take a look this week

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants