Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(purgecss-webpack-plugin): export as named export as well as default #821

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Dec 20, 2021

Proposed changes

This should provide a workaround for #820 by enabling importing the class via it's name as well as by default.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

While the types are still wrong, I think fixing them might be a heavy task as it depends on what is actually building the types & doing the packages - I'm happy to try help with that, but that requires having the whole project setup locally; this workaround will unblock people in the meantime.

@Ffloriel Ffloriel merged commit a6a2c8e into FullHuman:main Jan 1, 2022
@G-Rath G-Rath deleted the patch-1 branch January 1, 2022 23:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants