Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

incorrectExplosionExposureFix makes all explosions fail to interact with entities #51

Closed
Minepig opened this issue Apr 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Minepig
Copy link

Minepig commented Apr 19, 2022

When I enabled incorrectExplosionExposureFix, all explosion cannot push or damage entity (actually damage only a little bit).

I think I have found the problem:
(In file carpet-fixes/src/main/java/carpetfixes/mixins/coreSystemFixes/Explosion_exposureMixin.java)

@Mixin(Explosion.class)
public class Explosion_exposureMixin {
    private static void getExposure(Vec3d source, Entity entity, CallbackInfoReturnable<Float> cir) {
        if (CFSettings.incorrectExplosionExposureFix) {
            /* something */
            if (!(d < 0.0D) && !(e < 0.0D) && !(f < 0.0D)) {
                /* something */
                cir.setReturnValue((float)i / (float)j);
            }
            cir.setReturnValue(0.0F);
        }
    }
}

Doesn't it mean that all the calls to this method would return 0.0f?

I'm sorry that I can't send PR because I'm not familiar with modding. :(

@FxMorin FxMorin added the bug Something isn't working label Apr 20, 2022
@FxMorin
Copy link
Owner

FxMorin commented Apr 20, 2022

You don't need to tell me where the issue is, you just need to tell me the issue, and ill fix it. I need to fix one more bug today and then ill fix this one

FxMorin added a commit that referenced this issue Apr 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants