Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Refresh Terminologies Cache Functionality #178

Merged
merged 6 commits into from
Jun 19, 2020
Merged

Add Refresh Terminologies Cache Functionality #178

merged 6 commits into from
Jun 19, 2020

Conversation

fschrader1992
Copy link
Contributor

This PR:

mpsonntag
mpsonntag requested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation locks the editor until the refresh is done basically freezing the application for the user without feedback.

It would be better to run the actual refresh in the background.

mpsonntag
mpsonntag requested changes Jun 3, 2020
View reviewed changes
odmlui/editor.py Outdated Show resolved Hide resolved
@fschrader1992
Copy link
Contributor Author

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Test with Python3.8

@mpsonntag mpsonntag merged commit 771988e into G-Node:master Jun 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpsonntag mpsonntag mpsonntag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable clearing of Terminology cache
2 participants
@fschrader1992 @mpsonntag