Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Properties Reorder #180

Merged
merged 11 commits into from
Jun 22, 2020
Merged

Properties Reorder #180

merged 11 commits into from
Jun 22, 2020

Conversation

fschrader1992
Copy link
Contributor

This PR:

@fschrader1992
Copy link
Contributor Author

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Test with Python3.8

mpsonntag
mpsonntag approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks!

Will do a squash merge though since this PR contains too many commits that introduce changes that are removed by later commits in the same PR making the history unnecessarily hard to read.

@mpsonntag mpsonntag merged commit 3182e10 into G-Node:master Jun 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mpsonntag mpsonntag mpsonntag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschrader1992 @mpsonntag