Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Exclude id in the baseobject.__eq__() method #260

Closed
mpsonntag opened this issue Mar 20, 2018 · 0 comments · Fixed by #263
Closed

Exclude id in the baseobject.__eq__() method #260

mpsonntag opened this issue Mar 20, 2018 · 0 comments · Fixed by #263
Assignees
@mpsonntag

Comments

@mpsonntag
Copy link
Contributor

Since every odML entity should have a unique id, it should be excluded from the __eq__ method.

Required for #258.
@mpsonntag mpsonntag self-assigned this Mar 20, 2018
mpsonntag added a commit to mpsonntag/python-odml that referenced this issue Mar 20, 2018
@mpsonntag
[base] Exclude id from __eq__ check
9440534 
Closes G-Node#260

id should be unique for every entity,
therefore exclude it from equality check.
@mpsonntag mpsonntag mentioned this issue Mar 20, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mpsonntag mpsonntag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes and Section/Property tests mpsonntag/python-odml
1 participant
@mpsonntag